[GitHub] [airflow] vandonr-amz commented on a diff in pull request #29274: log the observed status in redshift sensor

["vandonr-amz (via GitHub)" <gi...@apache.org>]

vandonr-amz commented on code in PR #29274:
URL: https://github.com/apache/airflow/pull/29274#discussion_r1093469140


##########
airflow/providers/amazon/aws/sensors/redshift_cluster.py:
##########
@@ -56,8 +56,14 @@ def __init__(
         self.aws_conn_id = aws_conn_id
 
     def poke(self, context: Context):
-        self.log.info("Poking for status : %s\nfor cluster %s", self.target_status, self.cluster_identifier)
-        return self.hook.cluster_status(self.cluster_identifier) == self.target_status
+        current_status = self.hook.cluster_status(self.cluster_identifier)
+        self.log.info(
+            "Poked cluster %s for status '%s', found status '%s'",

Review Comment:
   I'd be happy to apply the suggestion, but can you explain why this would be better ? Both being strings, the output would be exactly the same, wouldn't it ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org