[GitHub] [incubator-doris] wangbo commented on a change in pull request #2075: Segment v2 stream load core dump(#2037)

[GitBox <gi...@apache.org>]

wangbo commented on a change in pull request #2075: Segment v2 stream load core dump(#2037)
URL: https://github.com/apache/incubator-doris/pull/2075#discussion_r341558444
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/column_writer.h
 ##########
 @@ -102,14 +102,13 @@ class ColumnWriter {
     struct Page {
         int32_t first_rowid;
         int32_t num_rows;
-        Slice null_bitmap = Slice((uint8_t*)nullptr, 0);
-        Slice data = Slice((uint8_t*)nullptr, 0);
+        Slice null_bitmap = Slice((const uint8_t*)nullptr, 0);
+        OwnedSlice data = OwnedSlice((uint8_t*)nullptr, 0);
 
 Review comment:
   null_bitmap produced by NullBitmapBuilder,and NullBitmapBuilder didn't implement PageBuilder,here just keep NullBitmapBuilder's origin Semantics.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org