You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/01 03:38:06 UTC
[GitHub] [arrow] kou opened a new pull request, #35376: GH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContext::incoming_headers()`
kou opened a new pull request, #35376:
URL: https://github.com/apache/arrow/pull/35376
### Rationale for this change
It returns headers sent by a client.
We can get them only in `arrow::flight::ServerMiddlewareCactory::StartCall()` for now. But they're useful for in each RPC call.
### What changes are included in this PR?
Add the method.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35376: GH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContext::incoming_headers()`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35376:
URL: https://github.com/apache/arrow/pull/35376#issuecomment-1529311415
* Closes: #35375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35376: GH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContext::incoming_headers()`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35376:
URL: https://github.com/apache/arrow/pull/35376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35376: GH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContext::incoming_headers()`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35376:
URL: https://github.com/apache/arrow/pull/35376#issuecomment-1529675391
Benchmark runs are scheduled for baseline = 0ea1a103dfc2fc4ab5a5d839369a805e2ae657a2 and contender = 75439f09a5eb6fbe21622dfb31c2be37a8cc0afd. 75439f09a5eb6fbe21622dfb31c2be37a8cc0afd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/fe87885954c5458baf3d19f5f5c745e1...d1e45c922f914bafae7811424e198ae0/)
[Failed :arrow_down:2.1% :arrow_up:0.18%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/10e4d724382a4301a13c7aa0ce29ecc7...e66b452251a8470b92983125895a52d8/)
[Failed :arrow_down:1.57% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e977f7ce25ff471b8479da32a205df65...56989b858e8a4b6c9a46b4620f330743/)
[Finished :arrow_down:1.6% :arrow_up:0.36%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c7510f47499147138bc4d1b6fb890100...0b74736e6b7146a2a5676c29c3f71889/)
Buildkite builds:
[Finished] [`75439f09` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2799)
[Failed] [`75439f09` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2833)
[Failed] [`75439f09` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2797)
[Finished] [`75439f09` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2824)
[Finished] [`0ea1a103` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2798)
[Failed] [`0ea1a103` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2832)
[Failed] [`0ea1a103` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2796)
[Finished] [`0ea1a103` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2823)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #35376: GH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContext::incoming_headers()`
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #35376:
URL: https://github.com/apache/arrow/pull/35376#discussion_r1181426600
##########
cpp/src/arrow/flight/test_util.cc:
##########
@@ -474,12 +474,31 @@ class FlightTestServer : public FlightServerBase {
return Status::OK();
}
+ Status ListIncomingHeaders(const ServerCallContext& context, const Action& action,
+ std::unique_ptr<ResultStream>* out) {
+ std::vector<Result> results;
+ auto prefix = static_cast<std::string_view>(*(action.body));
Review Comment:
nit, but IMO static_cast is a bit of a confusing way to write an implicit conversion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35376: GH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContext::incoming_headers()`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35376:
URL: https://github.com/apache/arrow/pull/35376#discussion_r1181441200
##########
cpp/src/arrow/flight/test_util.cc:
##########
@@ -474,12 +474,31 @@ class FlightTestServer : public FlightServerBase {
return Status::OK();
}
+ Status ListIncomingHeaders(const ServerCallContext& context, const Action& action,
+ std::unique_ptr<ResultStream>* out) {
+ std::vector<Result> results;
+ auto prefix = static_cast<std::string_view>(*(action.body));
Review Comment:
OK. How about `std::string_view prefix(*action.body)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35376: GH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContext::incoming_headers()`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35376:
URL: https://github.com/apache/arrow/pull/35376#issuecomment-1529311424
:warning: GitHub issue #35375 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org