[jira] [Resolved] (SLING-10779) ContentPackage2FeatureModelConverter.getAclManager should never return null

["Carsten Ziegeler (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-10779.
--------------------------------------
    Resolution: Fixed

Fixed in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/03613ebc1225a62b837ed05bb306a5cd2b3bbd9f by setting the DefaultAclManager.
I also changed the exception of that constructor to a RuntimeException as this indicates a wrong setup and not a problem with the to be converted content package

> ContentPackage2FeatureModelConverter.getAclManager should never return null
> ---------------------------------------------------------------------------
>
>                 Key: SLING-10779
>                 URL: https://issues.apache.org/jira/browse/SLING-10779
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content-Package to Feature Model Converter
>            Reporter: Angela Schreiber
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: Content-Package to Feature Model Converter 1.1.16
>
>
> {{ContentPackage2FeatureModelConverter.getAclManager}} is used across the converter code base and always expected to be not-null. so, instead of defining it as 'nullable' we should find ways to make sure it is always present on the converter. this would allow to get rid of Objects.requireNotNull and the warnings about potential NPE where the check is missing.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)