You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Dennis Kubes (JIRA)" <ji...@apache.org> on 2007/10/25 23:10:50 UTC
[jira] Created: (HADOOP-2102) ToolBase doesn't keep configuration
ToolBase doesn't keep configuration
-----------------------------------
Key: HADOOP-2102
URL: https://issues.apache.org/jira/browse/HADOOP-2102
Project: Hadoop
Issue Type: Bug
Components: util
Environment: All
Reporter: Dennis Kubes
Assignee: Dennis Kubes
Fix For: 0.15.0, 0.16.0
ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2102:
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.16.0)
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Dennis and Enis!
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537863 ]
Enis Soztutar commented on HADOOP-2102:
---------------------------------------
Dennis, we can just change :
{code}
public final int doMain(Configuration conf, String[] args) throws Exception {
return ToolRunner.run(conf, this, args);
}
{code}
I will apply the patch, but I think its better if nutch give up using ToolBase in the first place, since it will be removed soon.
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Fix For: 0.15.0, 0.16.0
>
> Attachments: NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538479 ]
Hudson commented on HADOOP-2102:
--------------------------------
Integrated in Hadoop-Nightly #286 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/286/])
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Dennis Kubes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Kubes updated HADOOP-2102:
---------------------------------
Attachment: NUTCH-2102-1.patch.sql
Simple patch, sets the configuration in ToolBase to the passed in configuration.
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Fix For: 0.15.0, 0.16.0
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Dennis Kubes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537984 ]
Dennis Kubes commented on HADOOP-2102:
--------------------------------------
Ah, I like your change better. If I had bothered to read ToolRunner I probably would have gone that route. :) We are going to stop using ToolBase for Nutch. Those changes will probably go into our current patch sets for upgrading to 0.15 hadoop. Just didn't want anything current to break upon upgrade.
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0, 0.16.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-2102:
----------------------------------
Status: Patch Available (was: Open)
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0, 0.16.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538198 ]
Enis Soztutar commented on HADOOP-2102:
---------------------------------------
So, me Arun and Devaraj agree that this is a blocker. I will commit this one to trunk and 0.15 unless any objections.
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0, 0.16.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538001 ]
Arun C Murthy commented on HADOOP-2102:
---------------------------------------
+1
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0, 0.16.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538164 ]
Devaraj Das commented on HADOOP-2102:
-------------------------------------
The core-tests failed due to HADOOP-2112. I think this patch can be committed ignoring the testcase failure.
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0, 0.16.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Dennis Kubes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Kubes updated HADOOP-2102:
---------------------------------
Attachment: (was: NUTCH-2102-1.patch.sql)
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Fix For: 0.15.0, 0.16.0
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538156 ]
Hadoop QA commented on HADOOP-2102:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12368485/HADOOP-2012-2.patch
against trunk revision r588778.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1014/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1014/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1014/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1014/console
This message is automatically generated.
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0, 0.16.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-2102:
----------------------------------
Priority: Blocker (was: Major)
Marking this as blocker for 0.15, since for this release we just deprecate ToolBase, there will be classes depending on correct behavior of it.
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0, 0.16.0
>
> Attachments: NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Dennis Kubes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Kubes updated HADOOP-2102:
---------------------------------
Attachment: NUTCH-2102-1.patch
Don't know why, first one got named as a sql file. Removed and re-uploaded as patch file.
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Fix For: 0.15.0, 0.16.0
>
> Attachments: NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-2102:
----------------------------------
Attachment: HADOOP-2012-2.patch
updated patch.
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0, 0.16.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2102) ToolBase doesn't keep configuration
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538414 ]
Owen O'Malley commented on HADOOP-2102:
---------------------------------------
+1
> ToolBase doesn't keep configuration
> -----------------------------------
>
> Key: HADOOP-2102
> URL: https://issues.apache.org/jira/browse/HADOOP-2102
> Project: Hadoop
> Issue Type: Bug
> Components: util
> Environment: All
> Reporter: Dennis Kubes
> Assignee: Dennis Kubes
> Priority: Blocker
> Fix For: 0.15.0, 0.16.0
>
> Attachments: HADOOP-2012-2.patch, NUTCH-2102-1.patch
>
>
> ToolBase which has been superceded by ToolRunner doesn't pass in an existing configuration object and therefore won't pick up initial configuration resources. One consequence of this is the nutch default and site.xml files are ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.