You are viewing a plain text version of this content. The canonical link for it is here.

Posted to solr-dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2010/01/12 01:04:54 UTC

[jira] Resolved: (SOLR-1588) FieldProperties contains large commented code block

     [ https://issues.apache.org/jira/browse/SOLR-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-1588.
----------------------------

    Resolution: Fixed
      Assignee: Hoss Man

makes sense to me.

Committed revision 898124.

> FieldProperties contains large commented code block
> ---------------------------------------------------
>
>                 Key: SOLR-1588
>                 URL: https://issues.apache.org/jira/browse/SOLR-1588
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.4
>         Environment: My local MacBook pro laptop.
>            Reporter: Chris A. Mattmann
>            Assignee: Hoss Man
>            Priority: Trivial
>             Fix For: 1.5
>
>         Attachments: SOLR-1588.Mattmann.112209.patch.txt
>
>
> Lines 102-133 in o.a.solr.schema.FieldProperties contain a large commented out block of code. It's generally a good thing to not commit this type of code -- if it's needed it can be looked up by the CM system for a prior revision. Trivial patch attached that removes the code block.
> (note I found this while trying to understand the FieldType hierarchy with the goal of working on SOLR-1586 to help out...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.