You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/23 23:26:04 UTC
[GitHub] [beam] rehmanmuradali opened a new pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
rehmanmuradali opened a new pull request #12433:
URL: https://github.com/apache/beam/pull/12433
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-668843184
Yes. It seems an issue that under the surface. We have to fix that to make bit_and merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-784595646
This pull request is no longer marked as stale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rehmanmuradali commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
rehmanmuradali commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-668846847
@amaliujia all aggregate functions implementation will be dependent on this ticket? I tried to change the NULL test case(initially bit_and) to bit_or and the issue reproduces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-920396272
The nullness issue was fixed and BIT_AND enabled in #15174.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] shehzaadn-vd commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
shehzaadn-vd commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-782515318
@ibzib @robinyqiu could you please help us reopen this PR?
cc: @sonam-vend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-668709642
@Imfuyuwei
can you provide the `NULL` test case that failed this implementation before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-743934718
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rehmanmuradali commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
rehmanmuradali commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-667078454
@reuvenlax @kennknowles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-669466436
My impression was bit_and crashed due to this special while others didn't (or not tested). That was why bit_and was disabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib closed pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
ibzib closed pull request #12433:
URL: https://github.com/apache/beam/pull/12433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia edited a comment on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-669466436
My impression was bit_and crashed due to this special case while others didn't (or not tested). That was why bit_and was disabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rehmanmuradali commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
rehmanmuradali commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-668839401
> Thanks @Imfuyuwei
>
> > Yes, one of my previous commit has some tests related to NULL case.
> > [a960772#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434](https://github.com/apache/beam/commit/a960772cde0a5e1d31f4de7c9349ad23f97954ce#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434)
>
> @rehmanmuradali can you check this test case and make sure it passes before get this PR merged?
@amaliujia the test is failing. Seems like the issue is reported here [BEAM-10379](https://issues.apache.org/jira/browse/BEAM-10379)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] closed pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #12433:
URL: https://github.com/apache/beam/pull/12433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rehmanmuradali edited a comment on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
rehmanmuradali edited a comment on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-667078454
R: @reuvenlax @kennknowles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-734494685
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-668768959
Thanks @Imfuyuwei
> Yes, one of my previous commit has some tests related to NULL case.
>
> [a960772#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434](https://github.com/apache/beam/commit/a960772cde0a5e1d31f4de7c9349ad23f97954ce#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434)
@rehmanmuradali can you check this test case and make sure it passes before get this PR merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Imfuyuwei commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn
Posted by GitBox <gi...@apache.org>.
Imfuyuwei commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-668732197
Yes, one of my previous commit has some tests related to NULL case.
https://github.com/apache/beam/pull/12110/commits/a960772cde0a5e1d31f4de7c9349ad23f97954ce#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org