You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/05/23 04:32:38 UTC

Review Request 59478: Fix SchedulingBenchmarks

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59478/
-----------------------------------------------------------

Review request for Aurora and Stephan Erb.


Repository: aurora


Description
-------

Fix SchedulingBenchmarks broken in Mesos Maintenance and Update Affinity patches.


Diffs
-----

  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f 


Diff: https://reviews.apache.org/r/59478/diff/1/


Testing
-------

./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.*'


Thanks,

David McLaughlin


Re: Review Request 59478: Fix SchedulingBenchmarks

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59478/#review175823
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On May 23, 2017, 6:32 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59478/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 6:32 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix SchedulingBenchmarks broken in Mesos Maintenance and Update Affinity patches.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f 
> 
> 
> Diff: https://reviews.apache.org/r/59478/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.*'
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 59478: Fix SchedulingBenchmarks

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59478/#review175822
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On May 22, 2017, 9:32 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59478/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 9:32 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix SchedulingBenchmarks broken in Mesos Maintenance and Update Affinity patches.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f 
> 
> 
> Diff: https://reviews.apache.org/r/59478/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.*'
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 59478: Fix SchedulingBenchmarks

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59478/#review175759
-----------------------------------------------------------


Ship it!




Master (4c0974b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On May 23, 2017, 4:32 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59478/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 4:32 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix SchedulingBenchmarks broken in Mesos Maintenance and Update Affinity patches.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f 
> 
> 
> Diff: https://reviews.apache.org/r/59478/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.*'
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>