[GitHub] [tvm] gromero commented on a diff in pull request #12125: [microTVM] Zephyr: Add support for FVP

[GitBox <gi...@apache.org>]

gromero commented on code in PR #12125:
URL: https://github.com/apache/tvm/pull/12125#discussion_r943999664


##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -578,49 +623,78 @@ def generate_project(self, model_library_format_path, standalone_crt_dir, projec
     def build(self, options):
         BUILD_DIR.mkdir()
 
-        check_call(["cmake", ".."], cwd=BUILD_DIR)
+        zephyr_board = _find_board_from_cmake_file(API_SERVER_DIR / CMAKELIST_FILENAME)
+        emu_platform = _find_platform_from_cmake_file(API_SERVER_DIR / CMAKELIST_FILENAME)
+
+        env = dict(os.environ)
+        if self._is_fvp(zephyr_board, emu_platform == "armfvp"):
+            env["ARMFVP_BIN_PATH"] = str(API_SERVER_DIR / "fvp-hack")

Review Comment:
   @mkatanbaf Could you please add a comment on top of the `chmod` code explaining it's a CI requirement as per David's explanation? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org