You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/02/21 19:04:33 UTC
[kudu-CR] [java] add test to reproduce KUDU-2267
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9071/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/9071/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@94
PS5, Line 94: assertEventuallyTrue("Not able to connect to all the masters",
: new BooleanExpression() {
: @Override
: public boolean get() throws Exception {
: ConnectToCluster connector = new ConnectToCluster(masterHostPorts);
: connector.connectToMasters(newClient.asyncClient.getMasterTable(), null,
: DEFAULT_SLEEP, Connection.CredentialsPolicy.ANY_CREDENTIALS);
: connector.getDeferred().join();
: List<Exception> s = connector.getExceptionsReceived();
: return s.size() == 0;
: }
: }, DEFAULT_SLEEP);
After discovering KUDU-2319, I guess that at some point the client might connected to the leader master really fast, while the outstanding requests to other masters could be cancelled; so no exceptions would be produced. So, I think this way of verifying that the client can connect to non-leader masters is not reliable. Also, it might happen that there were some re-elections among the masters, so eventually every master has played the leader role (but this might happen just for a small fraction of all runs, though).
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 21 Feb 2018 19:04:33 +0000
Gerrit-HasComments: Yes