[GitHub] [doris] englefly commented on a diff in pull request #18829: [enhancement](Nereids) two phase read for topn

["englefly (via GitHub)" <gi...@apache.org>]

englefly commented on code in PR #18829:
URL: https://github.com/apache/doris/pull/18829#discussion_r1172494689


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalTopN.java:
##########
@@ -39,7 +39,10 @@
  * Physical top-N plan.
  */
 public class PhysicalTopN<CHILD_TYPE extends Plan> extends AbstractPhysicalSort<CHILD_TYPE> implements TopN {
-    public static String TOPN_RUNTIME_FILTER = "topn_runtime_filter";
+
+    public static final String TOPN_OPT = "topn_opt";

Review Comment:
   why rename TOPN_RUNTIME_FILTER to TOPN_OPT?
   both topn-runtime-filter and topn-two-phase-read are opt of topN.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org