[GitHub] [pulsar] tisonkun commented on a diff in pull request #17275: [cleanup][broker][Modernizer] fix violations in pulsar-broker

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #17275:
URL: https://github.com/apache/pulsar/pull/17275#discussion_r971871452


##########
pulsar-broker/pom.xml:
##########
@@ -432,9 +432,15 @@
           <failOnViolations>true</failOnViolations>
           <javaVersion>17</javaVersion>
           <ignorePackages>
-            <ignorePackage>org.apache.pulsar.broker</ignorePackage>
+            <ignorePackage>org.apache.pulsar.broker.admin</ignorePackage>
+            <ignorePackage>org.apache.pulsar.broker.namespace</ignorePackage>
+            <ignorePackage>org.apache.pulsar.broker.service</ignorePackage>
+            <ignorePackage>org.apache.pulsar.broker.stats</ignorePackage>
             <ignorePackage>org.apache.pulsar.client</ignorePackage>
           </ignorePackages>
+          <exclusionPatterns>
+            <exclusionPattern>java/lang/StringBuffer."&lt;init&gt;":.*</exclusionPattern>

Review Comment:
   @youzipi may I ask the reason you add this pattern?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org