You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/09 18:47:59 UTC
[kudu-CR] [doc] mention the loadgen tool in the release notes
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5020
Change subject: [doc] mention the loadgen tool in the release notes
......................................................................
[doc] mention the loadgen tool in the release notes
Added information about the load generation tools into the 1.1.0 release
notes:
* 'insert-generated-rows' has been replaced with 'kudu test loadgen'
which adds some new functionality
Change-Id: I1a227c475b05cb394718812ae9c825022f67994d
---
M docs/release_notes.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/5020/1
--
To view, visit http://gerrit.cloudera.org:8080/5020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a227c475b05cb394718812ae9c825022f67994d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [doc] mention the loadgen tool in the release notes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [doc] mention the loadgen tool in the release notes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a227c475b05cb394718812ae9c825022f67994d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [doc] mention the loadgen tool in the release notes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: [doc] mention the loadgen tool in the release notes
......................................................................
[doc] mention the loadgen tool in the release notes
Added information about the load generation tools into the 1.1.0 release
notes:
* 'insert-generated-rows' has been replaced with 'kudu test loadgen'
which adds some new functionality
Change-Id: I1a227c475b05cb394718812ae9c825022f67994d
Reviewed-on: http://gerrit.cloudera.org:8080/5020
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/release_notes.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a227c475b05cb394718812ae9c825022f67994d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doc] mention the loadgen tool in the release notes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [doc] mention the loadgen tool in the release notes
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5020/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 64: * The `insert-generated-rows` tool has been removed.
> Was this a part of CLI earlier ? if not, I think the mentioning of this bei
That was a stand-alone binary outside of the 'kudu' umbrella tools. ok, will update.
PS1, Line 65: new
> probably redundant.
Done
PS1, Line 66: temporary
> may be s/temporary/new ?
Not sure that would bring clarity here. The idea was to mention that the tool can run either against temporary tables which it creates itself or against existing ones. Probably, I should drop 'already' or all the sentence altogether if it's so confusing.
--
To view, visit http://gerrit.cloudera.org:8080/5020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a227c475b05cb394718812ae9c825022f67994d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] mention the loadgen tool in the release notes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5020
to look at the new patch set (#2).
Change subject: [doc] mention the loadgen tool in the release notes
......................................................................
[doc] mention the loadgen tool in the release notes
Added information about the load generation tools into the 1.1.0 release
notes:
* 'insert-generated-rows' has been replaced with 'kudu test loadgen'
which adds some new functionality
Change-Id: I1a227c475b05cb394718812ae9c825022f67994d
---
M docs/release_notes.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/5020/2
--
To view, visit http://gerrit.cloudera.org:8080/5020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a227c475b05cb394718812ae9c825022f67994d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doc] mention the loadgen tool in the release notes
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: [doc] mention the loadgen tool in the release notes
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5020/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 64: * The `insert-generated-rows` tool has been removed.
Was this a part of CLI earlier ? if not, I think the mentioning of this being obsoleted @L67 is sufficient, instead of explicitly calling this out under CLI section.
PS1, Line 65: new
probably redundant.
PS1, Line 66: temporary
may be s/temporary/new ?
--
To view, visit http://gerrit.cloudera.org:8080/5020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a227c475b05cb394718812ae9c825022f67994d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes