[GitHub] [libcloud] Kami commented on pull request #1631: Fix object name prefix based filtering in the local storage driver

[GitBox <gi...@apache.org>]

Kami commented on pull request #1631:
URL: https://github.com/apache/libcloud/pull/1631#issuecomment-983921695


   @louis-van-der-stam I added another somewhat related change which makes the output of ``list_container_objects`` sorted based on the object name which should result in consistent and stable order across Python versions and implementations - 6a24f1e5941c10535e8dad7fa2def92bc92ee5de, 4cdf818a5a501c6dd06c8491b8cbbee3d316c4d5.
   
   Do you think that change could cause issues?
   
   I mean, it's possible that some code or change which relied on the previous order would break, but before this change, the order wasn't guaranteed anyway and was "arbitrary" and could be different across different Python versions and implementations.
   
   From Python docs on ``os.listdir`` on which ``os.walk`` relies on:
   
   > The list is in arbitrary order. It does not include the special entries '.' and '..' even if they are present in the directory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org