[jira] [Comment Edited] (FLINK-11042) testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is an invalid test

["Piotr Nowojski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755198#comment-16755198 ] 

Piotr Nowojski edited comment on FLINK-11042 at 1/29/19 4:48 PM:
-----------------------------------------------------------------

I am waiting for someone to review my PR that drops this test. I asked [~tzulitai] but if you can do it, you could do it as well :)


was (Author: pnowojski):
I was waiting for someone to review my PR that drops this test. I asked [~tzulitai] but if you can do it, you could do it as well :)

> testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is an invalid test
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-11042
>                 URL: https://issues.apache.org/jira/browse/FLINK-11042
>             Project: Flink
>          Issue Type: Bug
>          Components: Kinesis Connector
>    Affects Versions: 1.8.0
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: pull-request-available
>
> main point of testFlinkKafkaProducerFailTransactionCoordinatorBeforeNotify is to fail transaction coordinator (by using {{kafkaProducer.getTransactionCoordinatorId();}} ) and we expect that this will cause failure of Flink job. However that's not always the case. Maybe because transaction coordinator can be re-elected before {{KafkaProducer}} even notices it or for whatever the reason, sometimes the failure is not happening.
> Because of a bug in the test, if failure hasn't happened, the test will not fail.
> Generally speaking this test is invalid and should be dropped.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)