You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/04 07:51:32 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #8459:
[FLINK-12476] [State TTL] Consider setting a default background cleanup
strategy in StateTtlConfig
azagrebin commented on a change in pull request #8459: [FLINK-12476] [State TTL] Consider setting a default background cleanup strategy in StateTtlConfig
URL: https://github.com/apache/flink/pull/8459#discussion_r290168085
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -322,11 +329,22 @@ public Builder cleanupInRocksdbCompactFilter() {
*/
@Nonnull
public Builder cleanupInRocksdbCompactFilter(long queryTimeAfterNumEntries) {
- cleanupStrategies.activate(CleanupStrategies.Strategies.ROCKSDB_COMPACTION_FILTER,
+ strategies.put(CleanupStrategies.Strategies.ROCKSDB_COMPACTION_FILTER,
Review comment:
Could you move to the new line `CleanupStrategies.Strategies.ROCKSDB_COMPACTION_FILTER,`?
According to the code style, we move all arguments to the new line if the line is broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services