You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2001/10/22 15:04:12 UTC
cvs commit: httpd-2.0/server rfc1413.c
trawick 01/10/22 06:04:12
Modified: . CHANGES
server rfc1413.c
Log:
Fix some bungling of the remote port in rfc1413.c so that
IdentityCheck retrieves the proper user id instead of failing
and thus always returning "nobody."
Submitted by: Dick Streefland <Di...@xs4all.nl>
Reviewed by: Jeff Trawick
Revision Changes Path
1.400 +5 -0 httpd-2.0/CHANGES
Index: CHANGES
===================================================================
RCS file: /home/cvs/httpd-2.0/CHANGES,v
retrieving revision 1.399
retrieving revision 1.400
diff -u -r1.399 -r1.400
--- CHANGES 2001/10/21 01:24:35 1.399
+++ CHANGES 2001/10/22 13:04:11 1.400
@@ -1,5 +1,10 @@
Changes with Apache 2.0.27-dev
+ *) Fix some bungling of the remote port in rfc1413.c so that
+ IdentityCheck retrieves the proper user id instead of failing
+ and thus always returning "nobody."
+ [Dick Streefland <Di...@xs4all.nl>]
+
*) Introduced thread saftey for mod_rewrite's internal cache.
[Brian Pane <bp...@pacbell.net>]
1.43 +2 -4 httpd-2.0/server/rfc1413.c
Index: rfc1413.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/rfc1413.c,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- rfc1413.c 2001/07/18 16:56:55 1.42
+++ rfc1413.c 2001/10/22 13:04:12 1.43
@@ -195,11 +195,9 @@
char buffer[RFC1413_MAXDATA + 1];
char user[RFC1413_USERLEN + 1]; /* XXX */
apr_size_t buflen;
- apr_sockaddr_t *localsa;
- apr_socket_addr_get(&localsa, APR_LOCAL, sock);
- apr_sockaddr_port_get(&sav_our_port, localsa);
- sav_rmt_port = RFC1413_PORT;
+ apr_sockaddr_port_get(&sav_our_port, conn->local_addr);
+ apr_sockaddr_port_get(&sav_rmt_port, conn->remote_addr);
/* send the data */
buflen = apr_snprintf(buffer, sizeof(buffer), "%hu,%hu\r\n", sav_rmt_port,