You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/20 14:51:00 UTC

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

    [ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173295#comment-16173295 ] 

ASF GitHub Bot commented on FLINK-7638:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4688

    [FLINK-7638] [flip6] Port CurrentJobsOverviewHandler to new REST endpoint

    ## What is the purpose of the change
    
    Ports the CurrentJobsOverviewHandler to the new REST endpoint by letting it implement
    the LegacyRestHandler interface. This commit changes the JobDetails JSON such that it
    now contains the number of tasks for each ExecutionState, including SCHEDULED,
    DEPLOYING, CREATED and RECONCILING. These state will now also be displayed in the
    web frontend.
    
    ## Verifying this change
    
    - Have tested manually that the old web frontend is still working
    - Added `JobDetailsTest` and `MultipleJobsDetailsTest` which test the un/marshalling
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink portCurrentJobsOverviewHandler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4688
    
----
commit d794ac015dfa081f637b5bb490919cef7b3eed3a
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-18T14:18:19Z

    [FLINK-7534] Create LegacyRestHandlerAdapter for old REST handlers
    
    Introduce LegacyRestHandler interface which the old REST handler have to implement
    in order to make them usable for the RestServerEndpoint in combination with the
    LegacyRestHandlerAdapter. The LegacyRestHandlerAdapter extends the AbstractRestHandler
    and runs the LegacyRestHandler implementation.
    
    As an example, this commit ports the ClusterOverviewHandler to the new interface. The
    Dispatcher side still has to be properly implemented.

commit dd21855227b577c09ed69a43e31aad2bfd23f95a
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-21T13:11:08Z

    [FLINK-7535] Port DashboardConfigHandler to new REST endpoint
    
    Lets DashboardConfigHandler implement the LegacyRestHandler. Moreover, this
    commit defines the appropriate DashboardConfigurationHeaders.
    
    The DispatcherRestEndpoint registers the DashboardConfigHandler.
    
    This closes #4604.

commit 60c4ac7b0456167e0a3e4e067b7d6641ca7cd5b6
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-09-18T20:58:22Z

    [FLINK-7638] [flip6] Port CurrentJobsOverviewHandler to new REST endpoint
    
    Ports the CurrentJobsOverviewHandler to the new REST endpoint by letting it implement
    the LegacyRestHandler interface. This commit changes the JobDetails JSON such that it
    now contains the number of tasks for each ExecutionState, including SCHEDULED,
    DEPLOYING, CREATED and RECONCILING. These state will now also be displayed in the
    web frontend.

----


> Port CurrentJobsOverviewHandler to new REST endpoint
> ----------------------------------------------------
>
>                 Key: FLINK-7638
>                 URL: https://issues.apache.org/jira/browse/FLINK-7638
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> Port the existing {{CurrentJobsOverviewHandler}} to the new REST endpoint.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)