You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2019/10/10 09:02:35 UTC

Review Request 71607: RANGER-2615:Unable to create ranger role

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71607/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2615
    https://issues.apache.org/jira/browse/RANGER-2615


Repository: ranger


Description
-------

RANGER-2615:Unable to create ranger role


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java 4f7e9d5 


Diff: https://reviews.apache.org/r/71607/diff/1/


Testing
-------

- NPE during role creation was fixed in the patch


Thanks,

Ramesh Mani

Re: Review Request 71607: RANGER-2615:Unable to create ranger role

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71607/#review218183
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 10, 2019, 9:28 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71607/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2019, 9:28 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2615
>     https://issues.apache.org/jira/browse/RANGER-2615
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2615:Unable to create ranger role
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java 4f7e9d5 
> 
> 
> Diff: https://reviews.apache.org/r/71607/diff/2/
> 
> 
> Testing
> -------
> 
> - NPE during role creation was fixed in the patch
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 71607: RANGER-2615:Unable to create ranger role

Posted by Nikhil P <np...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71607/#review218179
-----------------------------------------------------------


Ship it!




Ship It!

- Nikhil P


On Oct. 10, 2019, 2:58 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71607/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2019, 2:58 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2615
>     https://issues.apache.org/jira/browse/RANGER-2615
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2615:Unable to create ranger role
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java 4f7e9d5 
> 
> 
> Diff: https://reviews.apache.org/r/71607/diff/2/
> 
> 
> Testing
> -------
> 
> - NPE during role creation was fixed in the patch
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 71607: RANGER-2615:Unable to create ranger role

Posted by Ramesh Mani <rm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71607/
-----------------------------------------------------------

(Updated Oct. 10, 2019, 9:28 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Fixed review comments


Bugs: RANGER-2615
    https://issues.apache.org/jira/browse/RANGER-2615


Repository: ranger


Description
-------

RANGER-2615:Unable to create ranger role


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java 4f7e9d5 


Diff: https://reviews.apache.org/r/71607/diff/2/

Changes: https://reviews.apache.org/r/71607/diff/1-2/


Testing
-------

- NPE during role creation was fixed in the patch


Thanks,

Ramesh Mani

Re: Review Request 71607: RANGER-2615:Unable to create ranger role

Posted by Nikhil P <np...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71607/#review218176
-----------------------------------------------------------



considering moving creation of new Globalstate inside createGlobalStateForRoleVersion method.


security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java
Line 77 (original), 78 (patched)
<https://reviews.apache.org/r/71607/#comment305736>

    can we add this creation of new XXGlobalState in this createGlobalStateForRoleVersion method itself in order to avoid future NPE's , so that caller method will not have to make sure that globalState is not null.


- Nikhil P


On Oct. 10, 2019, 2:32 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71607/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2019, 2:32 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2615
>     https://issues.apache.org/jira/browse/RANGER-2615
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2615:Unable to create ranger role
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java 4f7e9d5 
> 
> 
> Diff: https://reviews.apache.org/r/71607/diff/1/
> 
> 
> Testing
> -------
> 
> - NPE during role creation was fixed in the patch
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>