Re: [I] ReaderUtil.partitionByLeaf API design: ordinal tracking for scatter/gather pattern [lucene]

["gsmiller (via GitHub)" <gi...@apache.org>]

gsmiller commented on issue #15905:
URL: https://github.com/apache/lucene/issues/15905#issuecomment-5209454058

   Sorry for the long delay. I was away for a few months. I think this all sounds reasonable. I think I'm still slightly partial to a single API that includes the ordinals since I suspect the additional cost of tracking the ordinals probably isn't huge in an overall system, but at the same time, I acknowledge the desire to optimize where possible. So I think it's a fair approach to have the two APIs. We probably want to position them (via their javadoc) as one providing a subset of the functionality but being optimized for situations where the caller doesn't care about the ordinals? Look forward to seeing the PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org