You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Thiago Veronezi <th...@veronezi.org> on 2013/03/28 12:40:59 UTC
cosmetic changes
Dear commiters,
I was checking the stateless code a bit and I couldn't help to do some
cosmetic changes to the code.
The tests are passing and my applications are running as expected.
Please let me know if it brings any issue.
Log:
-removing unused internal deprecated "invoke" methods from all the
containers and the RpcContainer interface
-some cleaning up and cosmetic changes to StatelessContainer and
StatelessInstanceManager
-StatelessContainer: removing unused internal "public" methods
(getSecurityService and getInstanceManager)
-StatelessContainer: removing unnecessary "createEJBObject" method
-removing unused classes: RestrictedUserTransaction,
RpcContainerWrapper and TransactionAttribute
[]s,
Thiago.
Re: cosmetic changes
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1
*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
2013/3/28 Jean-Louis MONTEIRO <je...@gmail.com>
> I'm generally in favor of such a cleaning to avoid tons of unused code to
> maintain.
> Svn is there to help us restore in case we need it.
>
> Thanks for doing that
>
>
>
> 2013/3/28 Thiago Veronezi <th...@veronezi.org>
>
> > Dear commiters,
> >
> > I was checking the stateless code a bit and I couldn't help to do some
> > cosmetic changes to the code.
> > The tests are passing and my applications are running as expected.
> > Please let me know if it brings any issue.
> >
> > Log:
> > -removing unused internal deprecated "invoke" methods from all the
> > containers and the RpcContainer interface
> > -some cleaning up and cosmetic changes to StatelessContainer and
> > StatelessInstanceManager
> > -StatelessContainer: removing unused internal "public" methods
> > (getSecurityService and getInstanceManager)
> > -StatelessContainer: removing unnecessary "createEJBObject" method
> > -removing unused classes: RestrictedUserTransaction,
> > RpcContainerWrapper and TransactionAttribute
> >
> > []s,
> > Thiago.
> >
>
>
>
> --
> Jean-Louis
>
Re: cosmetic changes
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
I'm generally in favor of such a cleaning to avoid tons of unused code to
maintain.
Svn is there to help us restore in case we need it.
Thanks for doing that
2013/3/28 Thiago Veronezi <th...@veronezi.org>
> Dear commiters,
>
> I was checking the stateless code a bit and I couldn't help to do some
> cosmetic changes to the code.
> The tests are passing and my applications are running as expected.
> Please let me know if it brings any issue.
>
> Log:
> -removing unused internal deprecated "invoke" methods from all the
> containers and the RpcContainer interface
> -some cleaning up and cosmetic changes to StatelessContainer and
> StatelessInstanceManager
> -StatelessContainer: removing unused internal "public" methods
> (getSecurityService and getInstanceManager)
> -StatelessContainer: removing unnecessary "createEJBObject" method
> -removing unused classes: RestrictedUserTransaction,
> RpcContainerWrapper and TransactionAttribute
>
> []s,
> Thiago.
>
--
Jean-Louis