You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/10/07 21:46:29 UTC
[native-toolchain-CR] Fix missing bzip2 from SLES12 docker build
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14382
Change subject: Fix missing bzip2 from SLES12 docker build
......................................................................
Fix missing bzip2 from SLES12 docker build
The SLES12 docker build's assert-dependencies-present.py
phase was failing, because it was missing bzip2. This
adds bzip2 to the list of packages installed.
Testing:
- Built SLES12 docker images
- Ran a build with that image
Change-Id: Ia5b346ada9ba984b84233a38a01219f01225eae6
---
M docker/sles12.df
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/82/14382/1
--
To view, visit http://gerrit.cloudera.org:8080/14382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5b346ada9ba984b84233a38a01219f01225eae6
Gerrit-Change-Number: 14382
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] Fix missing bzip2 from SLES12 docker build
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14382 )
Change subject: Fix missing bzip2 from SLES12 docker build
......................................................................
Patch Set 1: Verified+1
Build docker container and build passes.
--
To view, visit http://gerrit.cloudera.org:8080/14382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5b346ada9ba984b84233a38a01219f01225eae6
Gerrit-Change-Number: 14382
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Oct 2019 22:11:48 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Fix missing bzip2 from SLES12 docker build
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14382 )
Change subject: Fix missing bzip2 from SLES12 docker build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5b346ada9ba984b84233a38a01219f01225eae6
Gerrit-Change-Number: 14382
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Oct 2019 21:59:25 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Fix missing bzip2 from SLES12 docker build
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14382 )
Change subject: Fix missing bzip2 from SLES12 docker build
......................................................................
Fix missing bzip2 from SLES12 docker build
The SLES12 docker build's assert-dependencies-present.py
phase was failing, because it was missing bzip2. This
adds bzip2 to the list of packages installed.
Testing:
- Built SLES12 docker images
- Ran a build with that image
Change-Id: Ia5b346ada9ba984b84233a38a01219f01225eae6
Reviewed-on: http://gerrit.cloudera.org:8080/14382
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M docker/sles12.df
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5b346ada9ba984b84233a38a01219f01225eae6
Gerrit-Change-Number: 14382
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>