You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2010/08/27 20:53:53 UTC
[jira] Created: (AVRO-639) python should print short name of
records
python should print short name of records
------------------------------------------
Key: AVRO-639
URL: https://issues.apache.org/jira/browse/AVRO-639
Project: Avro
Issue Type: Improvement
Components: python
Reporter: Doug Cutting
Fix For: 1.4.0
When printing a reference to a named schema, the non-full-name is preferred when the type's namespace is the same as its enclosing schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-639) python should print short name of
records
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-639:
------------------------------
Attachment: AVRO-639.patch
Here's a patch for this.
Note that this has the side-effect of masking AVRO-635, in that interop tests will now pass again with this patch. Since AVRO-635 is not a regression, I don't think it should block a release, but interop tests should pass in a release.
> python should print short name of records
> ------------------------------------------
>
> Key: AVRO-639
> URL: https://issues.apache.org/jira/browse/AVRO-639
> Project: Avro
> Issue Type: Improvement
> Components: python
> Reporter: Doug Cutting
> Fix For: 1.4.0
>
> Attachments: AVRO-639.patch
>
>
> When printing a reference to a named schema, the non-full-name is preferred when the type's namespace is the same as its enclosing schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-639) python should print short name of
records
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903543#action_12903543 ]
Philip Zeyliger commented on AVRO-639:
--------------------------------------
Python patch looks. Consider writing a quick test in test_schema.py; should be pretty easy.
> python should print short name of records
> ------------------------------------------
>
> Key: AVRO-639
> URL: https://issues.apache.org/jira/browse/AVRO-639
> Project: Avro
> Issue Type: Improvement
> Components: python
> Reporter: Doug Cutting
> Fix For: 1.4.0
>
> Attachments: AVRO-639.patch
>
>
> When printing a reference to a named schema, the non-full-name is preferred when the type's namespace is the same as its enclosing schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-639) python should print short name of
records
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903545#action_12903545 ]
Doug Cutting commented on AVRO-639:
-----------------------------------
I considered it. I'm already past the limits of my Python knowledge. Also, this isn't a bug, really. The prior output wasn't incorrect, just different, larger and triggers a bug in Ruby.
> python should print short name of records
> ------------------------------------------
>
> Key: AVRO-639
> URL: https://issues.apache.org/jira/browse/AVRO-639
> Project: Avro
> Issue Type: Improvement
> Components: python
> Reporter: Doug Cutting
> Fix For: 1.4.0
>
> Attachments: AVRO-639.patch
>
>
> When printing a reference to a named schema, the non-full-name is preferred when the type's namespace is the same as its enclosing schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-639) python should print short name of
records
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903540#action_12903540 ]
Doug Cutting commented on AVRO-639:
-----------------------------------
In retrospect, I agree. The "namespace" keyword should perhaps never have been introduced, and fully-qualified names should instead be used everywhere. But that would be an incompatible change, rendering some existing data unreadable. If you'd like to propose that, along with a migration plan, please file a separate issue.
Short-term, I'd like to roll a release candidate today that passes data interop tests. The bug in Ruby (AVRO-635) is not a regression, so needn't block the release. I'd certainly rather fix that bug than mask it here, and I tried, but I couldn't bluff my way far enough with Ruby to do it. (Whereas I could bluff my way far-enough with Python!) Perhaps Jeff will come through with a patch for AVRO-635 soon. But, if that doesn't happen, fixing this is an expedient way to move forward with a 1.4.0 release.
> python should print short name of records
> ------------------------------------------
>
> Key: AVRO-639
> URL: https://issues.apache.org/jira/browse/AVRO-639
> Project: Avro
> Issue Type: Improvement
> Components: python
> Reporter: Doug Cutting
> Fix For: 1.4.0
>
> Attachments: AVRO-639.patch
>
>
> When printing a reference to a named schema, the non-full-name is preferred when the type's namespace is the same as its enclosing schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-639) python should print short name of
records
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting resolved AVRO-639.
-------------------------------
Hadoop Flags: [Reviewed]
Resolution: Fixed
> python should print short name of records
> ------------------------------------------
>
> Key: AVRO-639
> URL: https://issues.apache.org/jira/browse/AVRO-639
> Project: Avro
> Issue Type: Improvement
> Components: python
> Reporter: Doug Cutting
> Fix For: 1.4.0
>
> Attachments: AVRO-639.patch
>
>
> When printing a reference to a named schema, the non-full-name is preferred when the type's namespace is the same as its enclosing schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-639) python should print short name of
records
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903552#action_12903552 ]
Philip Zeyliger commented on AVRO-639:
--------------------------------------
Alright, plus one.
I introduced this behavior recently in AVRO-620, btw. If it used to work before, it's because previously the schema that we printed out would be more like the schema that originally came in, but that's the wrong behavior if you're printing out a subschema.
> python should print short name of records
> ------------------------------------------
>
> Key: AVRO-639
> URL: https://issues.apache.org/jira/browse/AVRO-639
> Project: Avro
> Issue Type: Improvement
> Components: python
> Reporter: Doug Cutting
> Fix For: 1.4.0
>
> Attachments: AVRO-639.patch
>
>
> When printing a reference to a named schema, the non-full-name is preferred when the type's namespace is the same as its enclosing schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-639) python should print short name of
records
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903531#action_12903531 ]
Philip Zeyliger commented on AVRO-639:
--------------------------------------
BTW, given that we now prefer AvroIDL for generating these things, I'd be a big fan of deprecating short names and using fully qualified names in the JSON representation always.
> python should print short name of records
> ------------------------------------------
>
> Key: AVRO-639
> URL: https://issues.apache.org/jira/browse/AVRO-639
> Project: Avro
> Issue Type: Improvement
> Components: python
> Reporter: Doug Cutting
> Fix For: 1.4.0
>
> Attachments: AVRO-639.patch
>
>
> When printing a reference to a named schema, the non-full-name is preferred when the type's namespace is the same as its enclosing schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.