You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/19 18:16:19 UTC
[GitHub] [incubator-nuttx] acassis opened a new pull request #4703: esp32s2: Add RNG driver support and board profile example
acassis opened a new pull request #4703:
URL: https://github.com/apache/incubator-nuttx/pull/4703
## Summary
Add RNG driver support and board profile example
## Impact
Only ESP32S2
## Testing
esp32s2-saola-1 board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4703: esp32s2: Add RNG driver support and board profile example
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4703:
URL: https://github.com/apache/incubator-nuttx/pull/4703#discussion_r734790722
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -40,7 +40,8 @@ CMN_CSRCS += xtensa_puts.c xtensa_releasepending.c xtensa_releasestack.c
CMN_CSRCS += xtensa_reprioritizertr.c xtensa_schedsigaction.c
CMN_CSRCS += xtensa_sigdeliver.c xtensa_stackframe.c xtensa_udelay.c
CMN_CSRCS += xtensa_unblocktask.c xtensa_usestack.c
-CMN_CSRCS += esp32s2_systemreset.c
+
+CHIP_CSRCS += esp32s2_systemreset.c
Review comment:
This one must be moved below line 73, otherwise it will be overwritten by the attribution on line 71.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4703: esp32s2: Add RNG driver support and board profile example
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4703:
URL: https://github.com/apache/incubator-nuttx/pull/4703#discussion_r732144235
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -77,6 +77,10 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
+ifeq ($(CONFIG_ESP32S2_RNG),y)
+CMN_CSRCS += esp32s2_rng.c
Review comment:
```suggestion
CHIP_CSRCS += esp32s2_rng.c
```
RNG is specific to ESP32-S2.
There are other mistakes like this in this `Make.defs` file: `esp32s2_systemreset.c`, `esp32s2_idle.c`, `esp32s2_serial.c`.
`
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -77,6 +77,10 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
+ifeq ($(CONFIG_ESP32S2_RNG),y)
+CMN_CSRCS += esp32s2_rng.c
Review comment:
```suggestion
CHIP_CSRCS += esp32s2_rng.c
```
RNG is specific to ESP32-S2.
There are other mistakes like this in this `Make.defs` file: `esp32s2_systemreset.c`, `esp32s2_idle.c`, `esp32s2_serial.c`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4703: esp32s2: Add RNG driver support and board profile example
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4703:
URL: https://github.com/apache/incubator-nuttx/pull/4703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org