You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2024/04/12 13:41:18 UTC
[PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
vincbeck opened a new pull request, #38967:
URL: https://github.com/apache/airflow/pull/38967
Several times in the past, it happened that bug(s) were introduced in Airflow codebase which breaks all system tests. The issue is, we do not run system in Airflow CI, thus these bugs get merged and we need to fix them afterwards.
To prevent that, I'd like to add a step in Airflow CI to catch these bugs before merging. The idea is to create a dummy system test (a simple DAG using EmptyOperator) and run this system test as part of the CI.
[See Slack thread](https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1712772405407389).
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38967:
URL: https://github.com/apache/airflow/pull/38967#issuecomment-2051884361
Applied `full tests needed` label and reopened
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck closed pull request #38967: Add a generic system test in `tests/system/` and run it in the CI
URL: https://github.com/apache/airflow/pull/38967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #38967:
URL: https://github.com/apache/airflow/pull/38967#issuecomment-2057050997
All tests are passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #38967: Add a generic system test in `tests/system/` and run it in the CI
URL: https://github.com/apache/airflow/pull/38967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1562955354
##########
tests/system/conftest.py:
##########
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config, items: list[pytest.Item
rootdir = config.rootpath
for item in items:
rel_path = item.path.relative_to(rootdir)
+
+ # Provider system tests
match = re.match(".+/system/providers/([^/]+)", str(rel_path))
if match:
provider = match.group(1)
item.add_marker(pytest.mark.system(provider))
+
+ # Core system tests
+ match = re.match(".+/system/[^/]+", str(rel_path))
+ if match:
+ item.add_marker(pytest.mark.system("core"))
Review Comment:
Why do we need this? Couldn't we just put the system test in the `common` provider and it would be picked up as normal? Or are we worried that actual system tests would eventually live there and get accidentally run by the Airlfow CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38967:
URL: https://github.com/apache/airflow/pull/38967#issuecomment-2057098949
Yep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1562964822
##########
tests/system/conftest.py:
##########
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config, items: list[pytest.Item
rootdir = config.rootpath
for item in items:
rel_path = item.path.relative_to(rootdir)
+
+ # Provider system tests
match = re.match(".+/system/providers/([^/]+)", str(rel_path))
if match:
provider = match.group(1)
item.add_marker(pytest.mark.system(provider))
+
+ # Core system tests
+ match = re.match(".+/system/[^/]+", str(rel_path))
+ if match:
+ item.add_marker(pytest.mark.system("core"))
Review Comment:
As far as I understand, `common` is not a provider in itself. `common-io` and common-sql` are. So putting the system test in either of the two does not really makes sense to me. That's why I preferred putting it in core Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1562964822
##########
tests/system/conftest.py:
##########
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config, items: list[pytest.Item
rootdir = config.rootpath
for item in items:
rel_path = item.path.relative_to(rootdir)
+
+ # Provider system tests
match = re.match(".+/system/providers/([^/]+)", str(rel_path))
if match:
provider = match.group(1)
item.add_marker(pytest.mark.system(provider))
+
+ # Core system tests
+ match = re.match(".+/system/[^/]+", str(rel_path))
+ if match:
+ item.add_marker(pytest.mark.system("core"))
Review Comment:
As far as I understand, `common` is not a provider in itself. `common-io` and `common-sql` are. So putting the system test in either of the two does not really makes sense to me. That's why I preferred putting it in core Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1563072454
##########
tests/system/conftest.py:
##########
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config, items: list[pytest.Item
rootdir = config.rootpath
for item in items:
rel_path = item.path.relative_to(rootdir)
+
+ # Provider system tests
match = re.match(".+/system/providers/([^/]+)", str(rel_path))
if match:
provider = match.group(1)
item.add_marker(pytest.mark.system(provider))
+
+ # Core system tests
+ match = re.match(".+/system/[^/]+", str(rel_path))
+ if match:
+ item.add_marker(pytest.mark.system("core"))
Review Comment:
Got it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #38967:
URL: https://github.com/apache/airflow/pull/38967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a generic system test in `tests/system/` and run it in the CI [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #38967:
URL: https://github.com/apache/airflow/pull/38967#issuecomment-2057387105
I'm really glad to see this one merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org