You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@spamassassin.apache.org by William Taylor <wi...@corp.sonic.net> on 2008/10/06 20:30:11 UTC

whitelist_from_rcvd propigating between users

It would seem the whitelist_from_rcvd is incorrectly propigating to the wrong users in the same thread.
For example usera has "whitelist_from_rcvd *.sonic.net sonic.net" setup. If userb gets sent mail that is
processed by that same thread it will pickup the whitelist_from_rcvd from usera

Any ideas where I can look for answers on this to track it down?

Thanks,
  William


Re: whitelist_from_rcvd propigating between users

Posted by "Daryl C. W. O'Shea" <sp...@dostech.ca>.
On 09/10/2008 11:57 AM, Karsten Bräckelmann wrote:
> On Thu, 2008-10-09 at 08:33 -0700, William Taylor wrote:
>> On Mon, Oct 06, 2008 at 11:30:11AM -0700, William Taylor wrote:
>>> It would seem the whitelist_from_rcvd is incorrectly propigating to the wrong users in the same thread.
>>> For example usera has "whitelist_from_rcvd *.sonic.net sonic.net" setup. If userb gets sent mail that is
>>> processed by that same thread it will pickup the whitelist_from_rcvd from usera
>>>
>>> Any ideas where I can look for answers on this to track it down?
> 
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=4179
> 
> Daryl, I guess that's the one you where referring to? Fixed in 3.2.4.

Yes, that's the one.  Thanks... that's twice in a couple months I've
forgotten which bug it was.

Daryl


Re: whitelist_from_rcvd propigating between users

Posted by Karsten Bräckelmann <gu...@rudersport.de>.
On Thu, 2008-10-09 at 08:33 -0700, William Taylor wrote:
> On Mon, Oct 06, 2008 at 11:30:11AM -0700, William Taylor wrote:
> > It would seem the whitelist_from_rcvd is incorrectly propigating to the wrong users in the same thread.
> > For example usera has "whitelist_from_rcvd *.sonic.net sonic.net" setup. If userb gets sent mail that is
> > processed by that same thread it will pickup the whitelist_from_rcvd from usera
> > 
> > Any ideas where I can look for answers on this to track it down?

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=4179

Daryl, I guess that's the one you where referring to? Fixed in 3.2.4.

  guenther


-- 
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}


Re: whitelist_from_rcvd propigating between users

Posted by William Taylor <wi...@corp.sonic.net>.
On Thu, Oct 09, 2008 at 06:31:03PM +0200, Karsten Bräckelmann wrote:
> However, given that other user settings actually do work, this might
> even be isolated to some particular code, rather than a widespread oops.
> 
I could be wrong but it seems to only be happening with the whitelist_from_rcvd bit


Re: whitelist_from_rcvd propigating between users

Posted by Karsten Bräckelmann <gu...@rudersport.de>.
On Thu, 2008-10-09 at 09:19 -0700, William Taylor wrote:
> On Thu, Oct 09, 2008 at 06:16:30PM +0200, Karsten Bräckelmann wrote:
> > William, please search bugzilla for duplicates first. If you're positive
> > this issue hasn't been reported before, please feel free to file a new
> > bug, adding as much details as possible.  Thanks.
> 
> I did search and could only find #4179 but didn't really want to open another
> bug because this appears to be the same thing.

Nod, hence me poking Daryl and Justin. :)

If this turns out to be the same bug, but a different aspect which has
not been fixed, there are two possibilities:  Reopening the original
bug, or filing a new one.

Since the part about user rules has been fixed and released already, I'd
go with filing a new one specifically about user settings. We easily can
close it as duplicate later. ;)

However, given that other user settings actually do work, this might
even be isolated to some particular code, rather than a widespread oops.

  guenther


-- 
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}


Re: whitelist_from_rcvd propigating between users

Posted by William Taylor <wi...@corp.sonic.net>.
On Thu, Oct 09, 2008 at 06:16:30PM +0200, Karsten Bräckelmann wrote:
> William, please search bugzilla for duplicates first. If you're positive
> this issue hasn't been reported before, please feel free to file a new
> bug, adding as much details as possible.  Thanks.
> 
I did search and could only find #4179 but didn't really want to open another
bug because this appears to be the same thing.


Re: whitelist_from_rcvd propigating between users

Posted by "Daryl C. W. O'Shea" <sp...@dostech.ca>.
On 09/10/2008 12:16 PM, Karsten Bräckelmann wrote:
> On Thu, 2008-10-09 at 09:02 -0700, William Taylor wrote:
>> On Thu, Oct 09, 2008 at 05:53:30PM +0200, Karsten Bräckelmann wrote:

>> I replied with more information to Daryl's post but I must
>> have sent it directly to him instead of the list. I don't have the exact reply
>> handy but I am running  SpamAssassin 3.2.5 (2008-06-10)
>> The bug does seem to be very simmilar to bug# 4179

Yes, sorry, I did receive that and just haven't had the time to respond.

>> So maybe the bug still exists under different circumstances?

It's certainly the same sort of thing.  Different code though, so it
probably got overlooked.

> Yup, your follow-up didn't make it to the list. Anyway, now that we know
> about your SA version, we're getting somewhere. Still assuming bug 4179
> actually is the one Daryl was talking about...
> 
> Maybe it merely fixes issues with user *rules*, and the same bug with
> user settings slipped by unnoticed.  Daryl, Justin?

Yes, I don't recall anything in the patch that targetted non regex rule
copy issues.  Of course it's been nearly a year... but I think the only
thing that was fixed were actual regex type rules.

> William, please search bugzilla for duplicates first. If you're positive
> this issue hasn't been reported before, please feel free to file a new
> bug, adding as much details as possible.  Thanks.

Yes, please open a new bug and along with your problem report please
reference bug 4179.

Thanks,

Daryl


Re: whitelist_from_rcvd propigating between users

Posted by Karsten Bräckelmann <gu...@rudersport.de>.
On Thu, 2008-10-09 at 09:02 -0700, William Taylor wrote:
> On Thu, Oct 09, 2008 at 05:53:30PM +0200, Karsten Bräckelmann wrote:
> > To be a little more helpful and less snippy -- if you want more detailed
> > answers, and check if it might be a different bug than the one
> > mentioned, telling us about your SA version would be a smart first
> > move...
> 
> I wasn't being snippy.

Oh, I was. :)

> I replied with more information to Daryl's post but I must
> have sent it directly to him instead of the list. I don't have the exact reply
> handy but I am running  SpamAssassin 3.2.5 (2008-06-10)
> The bug does seem to be very simmilar to bug# 4179
> 
> So maybe the bug still exists under different circumstances?

Yup, your follow-up didn't make it to the list. Anyway, now that we know
about your SA version, we're getting somewhere. Still assuming bug 4179
actually is the one Daryl was talking about...

Maybe it merely fixes issues with user *rules*, and the same bug with
user settings slipped by unnoticed.  Daryl, Justin?


William, please search bugzilla for duplicates first. If you're positive
this issue hasn't been reported before, please feel free to file a new
bug, adding as much details as possible.  Thanks.

  guenther


-- 
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}


Re: whitelist_from_rcvd propigating between users

Posted by William Taylor <wi...@corp.sonic.net>.
On Thu, Oct 09, 2008 at 05:53:30PM +0200, Karsten Bräckelmann wrote:
> To be a little more helpful and less snippy -- if you want more detailed
> answers, and check if it might be a different bug than the one
> mentioned, telling us about your SA version would be a smart first
> move...
> 

I wasn't being snippy. I replied with more information to Daryl's post but I must
have sent it directly to him instead of the list. I don't have the exact reply
handy but I am running  SpamAssassin 3.2.5 (2008-06-10)
The bug does seem to be very simmilar to bug# 4179

So maybe the bug still exists under different circumstances?


Re: whitelist_from_rcvd propigating between users

Posted by Karsten Bräckelmann <gu...@rudersport.de>.
On Thu, 2008-10-09 at 08:33 -0700, William Taylor wrote:
> On Mon, Oct 06, 2008 at 11:30:11AM -0700, William Taylor wrote:
> > It would seem the whitelist_from_rcvd is incorrectly propigating to the wrong users in the same thread.
> > For example usera has "whitelist_from_rcvd *.sonic.net sonic.net" setup. If userb gets sent mail that is
> > processed by that same thread it will pickup the whitelist_from_rcvd from usera
> > 
> > Any ideas where I can look for answers on this to track it down?

https://issues.apache.org/SpamAssassin/

> I haven't herd any other responses on this. Should I file an official bug report ?

No.

Btw, what do mean, no "other responses"? Other than the one by Daryl,
telling you that it most likely is an old, known, and recently fixed
bug?

http://www.nabble.com/whitelist_from_rcvd-propigating-between-users-td19843581.html

To be a little more helpful and less snippy -- if you want more detailed
answers, and check if it might be a different bug than the one
mentioned, telling us about your SA version would be a smart first
move...

  guenther


-- 
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}


Re: whitelist_from_rcvd propigating between users

Posted by William Taylor <wi...@corp.sonic.net>.
On Mon, Oct 06, 2008 at 11:30:11AM -0700, William Taylor wrote:
> It would seem the whitelist_from_rcvd is incorrectly propigating to the wrong users in the same thread.
> For example usera has "whitelist_from_rcvd *.sonic.net sonic.net" setup. If userb gets sent mail that is
> processed by that same thread it will pickup the whitelist_from_rcvd from usera
> 
> Any ideas where I can look for answers on this to track it down?

I haven't herd any other responses on this. Should I file an official bug report ?



Re: whitelist_from_rcvd propigating between users

Posted by "Daryl C. W. O'Shea" <sp...@dostech.ca>.
On 06/10/2008 2:30 PM, William Taylor wrote:
> It would seem the whitelist_from_rcvd is incorrectly propigating to the wrong users in the same thread.
> For example usera has "whitelist_from_rcvd *.sonic.net sonic.net" setup. If userb gets sent mail that is
> processed by that same thread it will pickup the whitelist_from_rcvd from usera
> 
> Any ideas where I can look for answers on this to track it down?

There was a long standing issue with user configs being copied between
users.  It was fixed in a recent 3.2 release.  Unfortunately I cannot
remember the bug or which release it was fixed in.  Upgrading to the
latest 3.2 release should fix your issue.

Regards,

Daryl