You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/10 22:09:29 UTC
[GitHub] [beam] kennknowles opened a new pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
kennknowles opened a new pull request #11977:
URL: https://github.com/apache/beam/pull/11977
For context, see:
- https://tools.ietf.org/html/draft-knodel-terminology-01
- https://developers.google.com/style/inclusive-documentation#features-and-users
Blocked by configuration of other projects and vendored code:
- https://github.com/tox-dev/tox/issues/1491
- https://github.com/jenkinsci/ghprb-plugin/issues/784
- Generated storage_v1_messages.py (undocumented how we generated this!?)
- Many golang and vendored modules
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Samza | Spark
--- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-642944731
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-647693686
Filed https://issues.apache.org/jira/browse/BEAM-10300 for flake/failure at https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/2339/testReport/junit/org.apache.beam.sdk.io.jdbc/JdbcIOTest/testCustomFluentBackOffConfiguration/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-645612199
run java precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-642899747
Yes, once the upstream changes are in and released we will edit our config files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-642359468
Thanks for doing this Kenn.
Another one: https://github.com/apache/beam/blob/d5dd47b47cbdf0739ac1a28cb8fbd06becbdbae7/sdks/java/io/hadoop-format/src/test/resources/cassandra.yaml#L66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-645612655
Didn't see another Jira. Doesn't seem to be failing on mainline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
kennknowles merged pull request #11977:
URL: https://github.com/apache/beam/pull/11977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-644983989
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-647748753
Finally green!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-642932191
> Yes, once the upstream changes are in and released we will edit our config files.
Is it worth filing a JIRA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11977: Remove "whitelist" and "blacklist" terminology from repository where possible
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-645612154
Filed https://issues.apache.org/jira/browse/BEAM-10272 for CassandraIOTest failure on https://builds.apache.org/job/beam_PreCommit_Java_Commit/11785/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org