[GitHub] [jmeter] 3dgiordano opened a new issue, #5810: JMeterTreeNode addComponent overloads GUI operations

["3dgiordano (via GitHub)" <gi...@apache.org>]

3dgiordano opened a new issue, #5810:
URL: https://github.com/apache/jmeter/issues/5810

   ### Expected behavior
   
   When adding multiple elements in a short period of time, only recreate the UI of the focused component at the end of all operations.
   
   This is for check and analyze, it is a suggestion for improvement.
   
   ### Actual behavior
   
   Inside this block of operation
   https://github.com/apache/jmeter/blob/master/src/core/src/main/java/org/apache/jmeter/gui/tree/JMeterTreeModel.java#L158
   
   What happens is that on each addComponent operation, the UI of the component and the focused component in the UI are sent to update.
   
   When adding many components in a very short time, such as proxy recording, you may notice that the focused screen is being recreated for each recorded sample.
   Part of the problem is that getCurrentGui is called which reconfigures and redraws again.
   https://github.com/apache/jmeter/blob/d8a6876169ea6327b8c20f23445a472af32f4276/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/ProxyControl.java#L1217
   
   Perhaps it is possible to change the way or the moment in which it is sent to carry out these operations, so that it is after the addComponent is carried out so that the operation is at the end.
   
   I think the usage of that code block inside that "if" and the getCurrentGui it's like a trick or hack, maybe not is the best place to add this operations. 
   
   
   
   
   ### Steps to reproduce the problem
   
   If you use, for example, the http recorder and you managed to queue a large number of requests in a short time, in less than 200ms.
   If you have a screen in focus that takes time to redraw, you may notice the focused component redraw and refresh as all requests are processed.
   There are probably other ways to reproduce it.
   
   ### JMeter Version
   
   5.x
   
   ### Java Version
   
   +1.8
   
   ### OS Version
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on issue #5810: JMeterTreeNode addComponent overloads GUI operations

["FSchumacher (via GitHub)" <gi...@apache.org>]

FSchumacher commented on issue #5810:
URL: https://github.com/apache/jmeter/issues/5810#issuecomment-1517616203

   In other components (View Results Tree for example) we queued the changes and applied them together every second (or a bit faster). This might be possible to do here, too. Together with a new method to allow batched inserts?
   
   Would you like to create a PR for this? Do you suggest another route?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org