You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "LuchianMihai (via GitHub)" <gi...@apache.org> on 2025/02/03 16:12:38 UTC
[PR] feat: add arch depends for aurix tc397 board [nuttx]
LuchianMihai opened a new pull request, #15750:
URL: https://github.com/apache/nuttx/pull/15750
## Summary
While digging through code I've noticed that tricore board option was present on a stm32 chip config.
This is due to a missing depends on statement.
Mostly a preference/esthetic change?
## Impact
None regarding build process
tricore board will only show (in menuconfig) if tricore chip (tc397) arch is also selected.
## Testing
Manually.
Checked that the option is present if tc397 chip is selected, hidden otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add arch depends for aurix tc397 board [nuttx]
Posted by "LuchianMihai (via GitHub)" <gi...@apache.org>.
LuchianMihai commented on code in PR #15750:
URL: https://github.com/apache/nuttx/pull/15750#discussion_r1939971143
##########
boards/Kconfig:
##########
@@ -2202,6 +2202,7 @@ config ARCH_BOARD_SABRE_6QUAD
config ARCH_BOARD_TC397
bool "Infineon's AURIX TC397 board: KIT_A2G_TC397_5V_TFT"
+ depends on ARCH_CHIP_TC397
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add arch depends for aurix tc397 board [nuttx]
Posted by "LuchianMihai (via GitHub)" <gi...@apache.org>.
LuchianMihai commented on PR #15750:
URL: https://github.com/apache/nuttx/pull/15750#issuecomment-2631454967
That indent mismatch is bothering me, it's there regardless of tab or spaces use. Is there a .editorconfig or a guideline for indentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add arch depends for aurix tc397 board [nuttx]
Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on code in PR #15750:
URL: https://github.com/apache/nuttx/pull/15750#discussion_r1939829719
##########
boards/Kconfig:
##########
@@ -2202,6 +2202,7 @@ config ARCH_BOARD_SABRE_6QUAD
config ARCH_BOARD_TC397
bool "Infineon's AURIX TC397 board: KIT_A2G_TC397_5V_TFT"
+ depends on ARCH_CHIP_TC397
Review Comment:
remove spaces and use a TAB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add arch depends for aurix tc397 board [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao merged PR #15750:
URL: https://github.com/apache/nuttx/pull/15750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org