You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/10/15 18:21:15 UTC

[GitHub] rafaelweingartner closed pull request #2876: PULL_REQUEST_TEMPLATE: simplify and remove unpopular sections

rafaelweingartner closed pull request #2876: PULL_REQUEST_TEMPLATE: simplify and remove unpopular sections
URL: https://github.com/apache/cloudstack/pull/2876
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md
index 17adfe69a31..a7c739d0869 100644
--- a/PULL_REQUEST_TEMPLATE.md
+++ b/PULL_REQUEST_TEMPLATE.md
@@ -4,6 +4,10 @@
 <!-- For new features, provide link to FS, dev ML discussion etc. -->
 <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
 
+<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
+<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
+<!-- Fixes: # -->
+
 ## Types of changes
 <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
 - [ ] Breaking change (fix or feature that would cause existing functionality to change)
@@ -12,13 +16,6 @@
 - [ ] Enhancement (improves an existing feature and functionality)
 - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
 
-## GitHub Issue/PRs
-<!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->
-<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
-<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
-
-<!-- Fixes: # -->
-
 ## Screenshots (if appropriate):
 
 ## How Has This Been Tested?
@@ -27,13 +24,4 @@
 <!-- Include details of your testing environment, and the tests you ran to -->
 <!-- see how your change affects other areas of the code, etc. -->
 
-## Checklist:
-<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
-<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
-- [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
-- [ ] My code follows the code style of this project.
-- [ ] My change requires a change to the documentation.
-- [ ] I have updated the documentation accordingly.
-- [ ] I have added tests to cover my changes.
-- [ ] All new and existing tests passed.
-
+<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services