[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6101: Docs: Update spotless apply command for non-default versions

[GitBox <gi...@apache.org>]

ajantha-bhat commented on code in PR #6101:
URL: https://github.com/apache/iceberg/pull/6101#discussion_r1011371634


##########
README.md:
##########
@@ -58,6 +58,8 @@ Iceberg is built using Gradle with Java 1.8 or Java 11.
 * To invoke a build and run tests: `./gradlew build`
 * To skip tests: `./gradlew build -x test -x integrationTest`
 * To fix code style: `./gradlew spotlessApply`
+  The above command applies to default versions. 
+  Need to pass the non-default versions via `-DsparkVersions`, `-DflinkVersions`, `-DhiveVersions` argument

Review Comment:
   I intentionally didn't add the example thinking that we need to modify the `ReadMe.md` each time we change the version number.  (when a new version is added or the old version is removed)
   
   But thinking more about it, maybe it is ok to add it. 
   
   I have added it now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org