You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Semb Wever (Jira)" <ji...@apache.org> on 2021/01/08 13:59:00 UTC
[jira] [Commented] (CASSANDRA-16279) Incorrect check for -Xlog in
cassandra-env.sh
[ https://issues.apache.org/jira/browse/CASSANDRA-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261320#comment-17261320 ]
Michael Semb Wever commented on CASSANDRA-16279:
------------------------------------------------
CI runs
- circleci j8 https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/8/workflows/4105826e-5499-487f-a90d-f8e277d57e0f
- circleci j11 https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/8/workflows/255d38bc-facd-4eb7-8a81-54ccebba441e
- ci-cassandra https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/279/
> Incorrect check for -Xlog in cassandra-env.sh
> ----------------------------------------------
>
> Key: CASSANDRA-16279
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16279
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Reporter: Yakir Gibraltar
> Assignee: Adam Holmberg
> Priority: Normal
> Fix For: 4.0-beta
>
>
> Possible small bug in {{cassandra-env.sh}} of Cassandra 4:
> [https://github.com/apache/cassandra/blob/trunk/conf/cassandra-env.sh#L98]
> The following command incorrect:
> {code}
> echo "$JVM_OPTS" | grep -q "^-[X]log:gc"
> {code}
> Should be:
> {code}
> echo "$JVM_OPTS" | grep -qe "-[X]log:gc"
> {code}
> The variable {{$JVM_OPTS}} not starting with {{-Xlog..}} , and always return 1, remove {{^}} and add {{-qe}} will solve the problem.
> It's causing that {{cassandra-env.sh}} ignoring variable of {{-Xlog}} in {{jvm11-server.options}} and {{jvm8-server.options}}
>
> Right now, jvm11-server.options with:
> {code:java}
> -Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=100M{code}
> Will generate process of:
> {code:java}
> -Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=100M -Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=10485760
> {code}
> With fix it will generate correct gc option of :
> {code}
> -Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=100M
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org