You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gora.apache.org by le...@apache.org on 2015/09/04 16:46:41 UTC
[1/3] gora git commit: Non-final public static fields can be changed
by external classes (by a malicious code or accidentally).
Repository: gora
Updated Branches:
refs/heads/master d4797dc28 -> 6cdbe565f
Non-final public static fields can be changed by external classes (by a malicious code or accidentally).
Project: http://git-wip-us.apache.org/repos/asf/gora/repo
Commit: http://git-wip-us.apache.org/repos/asf/gora/commit/c8550d35
Tree: http://git-wip-us.apache.org/repos/asf/gora/tree/c8550d35
Diff: http://git-wip-us.apache.org/repos/asf/gora/diff/c8550d35
Branch: refs/heads/master
Commit: c8550d3558d1a438b64409bcbac94f072c191d23
Parents: 3cf5502
Author: Furkan KAMACI <fu...@gmail.com>
Authored: Thu Sep 3 22:19:03 2015 +0300
Committer: Furkan KAMACI <fu...@gmail.com>
Committed: Thu Sep 3 22:19:03 2015 +0300
----------------------------------------------------------------------
gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/gora/blob/c8550d35/gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java
----------------------------------------------------------------------
diff --git a/gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java b/gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java
index f89762c..184b2c6 100644
--- a/gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java
+++ b/gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java
@@ -165,7 +165,7 @@ public class SolrStore<K, T extends PersistentBase> extends DataStoreBase<K, T>
* Default schema index with value "0" used when AVRO Union data types are
* stored
*/
- public static int DEFAULT_UNION_SCHEMA = 0;
+ public static final int DEFAULT_UNION_SCHEMA = 0;
/*
* Create a threadlocal map for the datum readers and writers, because they
[2/3] gora git commit: Non-final public static fields can be changed
by external classes (by a malicious code or accidentally).
Posted by le...@apache.org.
Non-final public static fields can be changed by external classes (by a malicious code or accidentally).
Project: http://git-wip-us.apache.org/repos/asf/gora/repo
Commit: http://git-wip-us.apache.org/repos/asf/gora/commit/4086ece8
Tree: http://git-wip-us.apache.org/repos/asf/gora/tree/4086ece8
Diff: http://git-wip-us.apache.org/repos/asf/gora/diff/4086ece8
Branch: refs/heads/master
Commit: 4086ece8cd2f9cd7a29bf46a1d290313c4e44d14
Parents: c8550d3
Author: Furkan KAMACI <fu...@gmail.com>
Authored: Thu Sep 3 22:51:57 2015 +0300
Committer: Furkan KAMACI <fu...@gmail.com>
Committed: Thu Sep 3 22:51:57 2015 +0300
----------------------------------------------------------------------
.../java/org/apache/gora/cassandra/store/CassandraStore.java | 4 ++--
.../src/main/java/org/apache/gora/compiler/GoraCompiler.java | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/gora/blob/4086ece8/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java
----------------------------------------------------------------------
diff --git a/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java b/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java
index dc4cf06..0c98162 100644
--- a/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java
+++ b/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java
@@ -96,12 +96,12 @@ public class CassandraStore<K, T extends PersistentBase> extends DataStoreBase<K
* Fixed string with value "UnionIndex" used to generate an extra column based on
* the original field's name
*/
- public static String UNION_COL_SUFIX = "_UnionIndex";
+ public static final String UNION_COL_SUFIX = "_UnionIndex";
/**
* Default schema index with value "0" used when AVRO Union data types are stored
*/
- public static int DEFAULT_UNION_SCHEMA = 0;
+ public static final int DEFAULT_UNION_SCHEMA = 0;
/**
* The values are Avro fields pending to be stored.
http://git-wip-us.apache.org/repos/asf/gora/blob/4086ece8/gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java
----------------------------------------------------------------------
diff --git a/gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java b/gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java
index f0a04f4..3b9846f 100644
--- a/gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java
+++ b/gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java
@@ -36,7 +36,7 @@ import org.codehaus.jackson.node.JsonNodeFactory;
public class GoraCompiler extends SpecificCompiler {
- public static String DIRTY_BYTES_FIELD_NAME = "__g__dirty";
+ public static final String DIRTY_BYTES_FIELD_NAME = "__g__dirty";
public static final int FIRST_UNMANAGED_FIELD_INDEX = 1;
private static final Set<String> GORA_RESERVED_NAMES = new HashSet<String>();
[3/3] gora git commit: GORA-433 Non-Final Public Static Fields Should
Be Final
Posted by le...@apache.org.
GORA-433 Non-Final Public Static Fields Should Be Final
Project: http://git-wip-us.apache.org/repos/asf/gora/repo
Commit: http://git-wip-us.apache.org/repos/asf/gora/commit/6cdbe565
Tree: http://git-wip-us.apache.org/repos/asf/gora/tree/6cdbe565
Diff: http://git-wip-us.apache.org/repos/asf/gora/diff/6cdbe565
Branch: refs/heads/master
Commit: 6cdbe565f9e1b59adef38442124274eafe399ccd
Parents: d4797dc 4086ece
Author: Lewis John McGibbney <le...@jpl.nasa.gov>
Authored: Fri Sep 4 07:47:41 2015 -0700
Committer: Lewis John McGibbney <le...@jpl.nasa.gov>
Committed: Fri Sep 4 07:47:41 2015 -0700
----------------------------------------------------------------------
CHANGES.txt | 2 ++
.../java/org/apache/gora/cassandra/store/CassandraStore.java | 4 ++--
.../src/main/java/org/apache/gora/compiler/GoraCompiler.java | 3 ++-
.../src/main/java/org/apache/gora/solr/store/SolrStore.java | 2 +-
4 files changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/gora/blob/6cdbe565/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index 8b79248,1ac61d5..bd763d5
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -2,27 -2,8 +2,29 @@@
==CHANGES.txt
=======================================================================
-Apache Gora 0.6.1 Release - 02/03/2015 (dd/mm/yyyy)
-Release Report - http://s.apache.org/l69
+Current Development
+
++* GORA-433 Non-Final Public Static Fields Should Be Final (Furkan KAMACI via lewismc)
++
+* GORA-314 Implement TestDriver for AccumuloStoreTest e.g. TODO in class (lewismc)
+
+* GORA-417 Deploy Hadoop-1 compatible binaries for Apache Gora (lewismc)
+
+* GORA-432 Simplify if Statements (Furkan KAMACI via lewismc)
+
+* GORA-386 Gora Spark Backend Support (Furkan KAMACI, talat, lewismc)
+
+* GORA-429 Implement Maven forbidden-apis plugin in Gora (lewismc, rmarroquin)
+
+* GORA-228 java.util.ConcurrentModificationException when using MemStore for concurrent tests (Yasin Kılınç, cihad güzel, lewismc)
+
+* GORA-419: AccumuloStore.put deletes entire row when updating map/array field (gerhardgossen via lewismc)
+
+* GORA-420: AccumuloStore.createSchema fails when table already exists (gerhardgossen via lewismc)
+
+* GORA-427 Configure MongoDB ReadPreference and WriteConcern (drazzib)
+
+* GORA-426 MongoDB cursor timeout on long running parse job (Alexander Yastrebov via drazzib)
* GORA-424 Cache cursor size to improve performance (Alexander Yastrebov via drazzib)
http://git-wip-us.apache.org/repos/asf/gora/blob/6cdbe565/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/gora/blob/6cdbe565/gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java
----------------------------------------------------------------------
diff --cc gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java
index 16a6372,3b9846f..53bde3c
--- a/gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java
+++ b/gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java
@@@ -34,14 -34,9 +34,15 @@@ import org.apache.avro.compiler.specifi
import org.codehaus.jackson.JsonNode;
import org.codehaus.jackson.node.JsonNodeFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
public class GoraCompiler extends SpecificCompiler {
+ private static final Logger LOG = LoggerFactory.getLogger(GoraCompiler.class);
+
- public static String DIRTY_BYTES_FIELD_NAME = "__g__dirty";
+ public static final String DIRTY_BYTES_FIELD_NAME = "__g__dirty";
++
public static final int FIRST_UNMANAGED_FIELD_INDEX = 1;
private static final Set<String> GORA_RESERVED_NAMES = new HashSet<String>();
http://git-wip-us.apache.org/repos/asf/gora/blob/6cdbe565/gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java
----------------------------------------------------------------------