[GitHub] [tvm] Mousius commented on a change in pull request #9565: [TIR][USMP] Integrating USMP to AoT Executor

[GitBox <gi...@apache.org>]

Mousius commented on a change in pull request #9565:
URL: https://github.com/apache/tvm/pull/9565#discussion_r786647414



##########
File path: src/target/source/codegen_source_base.h
##########
@@ -52,6 +52,18 @@ class CodeGenSourceBase {
    * \param value The constant value.
    */
   void MarkConst(std::string value);
+  /*!
+   * Print Type represetnation of type t.
+   * \param t The type representation.
+   * \param os The stream to print the ctype into
+   */
+  virtual void PrintType(DataType t, std::ostream& os);  // NOLINT(*)
+  /*!
+   * Print Type represetnation of type type.
+   * \param type The type representation.

Review comment:
       Can we use the same names in both of these blocks? i.e. `type type` or `type t` ? 
   
   Also minor typo:
   ```suggestion
      * Print Type representation of type type.
      * \param type The type representation.
   ```

##########
File path: src/target/source/codegen_source_base.h
##########
@@ -52,6 +52,18 @@ class CodeGenSourceBase {
    * \param value The constant value.
    */
   void MarkConst(std::string value);
+  /*!
+   * Print Type represetnation of type t.

Review comment:
       ```suggestion
      * Print Type representation of type t.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org