You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/02/03 16:38:59 UTC
[Impala-ASF-CR] IMPALA-9174: Emit WARNING when ORC lib leaks memory
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15153
Change subject: IMPALA-9174: Emit WARNING when ORC lib leaks memory
......................................................................
IMPALA-9174: Emit WARNING when ORC lib leaks memory
Added a check to OrcMemPool to test whether there was leaked memory
by the ORC library. Impala frees these memory anyway, but it's useful
to know if there is a bug in the ORC lib.
Testing:
* I tested manually
* I couldn't add an automated test because currently we are not aware
of such bugs in the lib
Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
---
M be/src/exec/hdfs-orc-scanner.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/15153/1
--
To view, visit http://gerrit.cloudera.org:8080/15153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
Gerrit-Change-Number: 15153
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9174: Emit WARNING when ORC lib leaks memory
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15153 )
Change subject: IMPALA-9174: Emit WARNING when ORC lib leaks memory
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
Gerrit-Change-Number: 15153
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Feb 2020 10:05:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9174: Emit WARNING when ORC lib leaks memory
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15153 )
Change subject: IMPALA-9174: Emit WARNING when ORC lib leaks memory
......................................................................
IMPALA-9174: Emit WARNING when ORC lib leaks memory
Added a check to OrcMemPool to test whether there was leaked memory
by the ORC library. Impala frees these memory anyway, but it's useful
to know if there is a bug in the ORC lib.
Testing:
* I tested manually
* I couldn't add an automated test because currently we are not aware
of such bugs in the lib
Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
Reviewed-on: http://gerrit.cloudera.org:8080/15153
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-orc-scanner.cc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
Gerrit-Change-Number: 15153
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9174: Emit WARNING when ORC lib leaks memory
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15153 )
Change subject: IMPALA-9174: Emit WARNING when ORC lib leaks memory
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
Gerrit-Change-Number: 15153
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Feb 2020 14:56:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9174: Emit WARNING when ORC lib leaks memory
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15153 )
Change subject: IMPALA-9174: Emit WARNING when ORC lib leaks memory
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5594/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
Gerrit-Change-Number: 15153
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 17:24:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9174: Emit WARNING when ORC lib leaks memory
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15153 )
Change subject: IMPALA-9174: Emit WARNING when ORC lib leaks memory
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5284/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
Gerrit-Change-Number: 15153
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Feb 2020 10:05:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9174: Emit WARNING when ORC lib leaks memory
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15153 )
Change subject: IMPALA-9174: Emit WARNING when ORC lib leaks memory
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
Gerrit-Change-Number: 15153
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 12:35:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9174: Emit WARNING when ORC lib leaks memory
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15153 )
Change subject: IMPALA-9174: Emit WARNING when ORC lib leaks memory
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I370fb9f68734e0e555bd7224ab0f5440c4947c66
Gerrit-Change-Number: 15153
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 02:37:07 +0000
Gerrit-HasComments: No