[jira] [Updated] (COUCHDB-1852) Last-Event-ID header should be honoured in eventsource _changes feed

["Damjan Georgievski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/COUCHDB-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Damjan Georgievski updated COUCHDB-1852:
----------------------------------------

    Attachment: draft.patch

Here's a patch fixing this issue. This one works, but I could make it better if I move the line 

{{ChangesFun = couch_changes:handle_changes}}

under the whole {{ case ChangesArgs#changes_args.feed of}} block
                
> Last-Event-ID header should be honoured in eventsource _changes feed
> --------------------------------------------------------------------
>
>                 Key: COUCHDB-1852
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1852
>             Project: CouchDB
>          Issue Type: Bug
>          Components: HTTP Interface
>            Reporter: Damjan Georgievski
>         Attachments: draft.patch
>
>
> When using the EventSource _changes feed support, the browser API will automatically reconnect and send the last sequence it received in the Last-Event-ID header.
> The server side needs to use the Last-Event-ID instead of the 'since' query string as a starting point for the changes feed.
> You can see the issue by simply creating a database and adding documents and watching what happens to the eventsource _changes feed.
> To see the feed with curl use:
> {{curl -i -H 'Last-Event-ID: 2' 'http://localhost:5984/testdb/_changes?feed=eventsource'}}
> the header should also have priority over the since query string:
> {{curl -i -H 'Last-Event-ID: 2' 'http://localhost:5984/testdb/_changes?feed=eventsource?since=1'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira