You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/07/07 03:02:14 UTC

[kudu-CR] Make the error message, for Status::AlreadyPresent() on row insertion, consistent

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3584

Change subject: Make the error message, for Status::AlreadyPresent() on row insertion, consistent
......................................................................

Make the error message, for Status::AlreadyPresent() on row insertion, consistent

Change-Id: I2f8775452ec45056e256e008c6fb4567e10c64ee
---
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/tablet-test.cc
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/3584/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f8775452ec45056e256e008c6fb4567e10c64ee
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>

[kudu-CR] Make the error message, for Status::AlreadyPresent() on row insertion, consistent

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.

Change subject: Make the error message, for Status::AlreadyPresent() on row insertion, consistent
......................................................................


Make the error message, for Status::AlreadyPresent() on row insertion, consistent

Change-Id: I2f8775452ec45056e256e008c6fb4567e10c64ee
Reviewed-on: http://gerrit.cloudera.org:8080/3584
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/tablet-test.cc
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f8775452ec45056e256e008c6fb4567e10c64ee
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Make the error message, for Status::AlreadyPresent() on row insertion, consistent

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Make the error message, for Status::AlreadyPresent() on row insertion, consistent
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f8775452ec45056e256e008c6fb4567e10c64ee
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Make the error message, for Status::AlreadyPresent() on row insertion, consistent

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Make the error message, for Status::AlreadyPresent() on row insertion, consistent
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2216/

-- 
To view, visit http://gerrit.cloudera.org:8080/3584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f8775452ec45056e256e008c6fb4567e10c64ee
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No