You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Hasan Ceylan (JIRA)" <ji...@apache.org> on 2009/09/12 12:48:57 UTC
[jira] Created: (DIRSTUDIO-540) Patch to copy source bundles along
with bundles during
Patch to copy source bundles along with bundles during
-------------------------------------------------------
Key: DIRSTUDIO-540
URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
Project: Directory Studio
Issue Type: Bug
Environment: N/A
Reporter: Hasan Ceylan
Attachments: studio-source-include.patch
studio-maven-plugin currently does not copy source artifacts.
The attached path deals with that.
It introduces two configuration parameters to copy-eclipse-artifact mojo:
1) includeSources : if we should include source artifacts
2) relaxed: if we should keep going is a source artifact cannot be found
Regards,
Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-540) Patch to copy source bundles
along with bundles during
Posted by "Hasan Ceylan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764237#action_12764237 ]
Hasan Ceylan commented on DIRSTUDIO-540:
----------------------------------------
Thanks Felix for letting the patch go through...
> Patch to copy source bundles along with bundles during
> -------------------------------------------------------
>
> Key: DIRSTUDIO-540
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
> Project: Directory Studio
> Issue Type: Improvement
> Environment: N/A
> Reporter: Hasan Ceylan
> Assignee: Felix Knecht
> Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-540) Patch to copy source bundles
along with bundles during
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763051#action_12763051 ]
Stefan Seelmann commented on DIRSTUDIO-540:
-------------------------------------------
Sorry Felix, no hurry. I just walk through the open issues...
> Patch to copy source bundles along with bundles during
> -------------------------------------------------------
>
> Key: DIRSTUDIO-540
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
> Project: Directory Studio
> Issue Type: Improvement
> Environment: N/A
> Reporter: Hasan Ceylan
> Assignee: Felix Knecht
> Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DIRSTUDIO-540) Patch to copy source bundles along
with bundles during
Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Knecht reassigned DIRSTUDIO-540:
--------------------------------------
Assignee: Felix Knecht
> Patch to copy source bundles along with bundles during
> -------------------------------------------------------
>
> Key: DIRSTUDIO-540
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
> Project: Directory Studio
> Issue Type: Improvement
> Environment: N/A
> Reporter: Hasan Ceylan
> Assignee: Felix Knecht
> Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-540) Patch to copy source bundles along
with bundles during
Posted by "Hasan Ceylan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hasan Ceylan updated DIRSTUDIO-540:
-----------------------------------
Attachment: studio-source-include.patch
> Patch to copy source bundles along with bundles during
> -------------------------------------------------------
>
> Key: DIRSTUDIO-540
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
> Project: Directory Studio
> Issue Type: Bug
> Environment: N/A
> Reporter: Hasan Ceylan
> Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSTUDIO-540) Patch to copy source bundles along
with bundles during
Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Knecht closed DIRSTUDIO-540.
----------------------------------
> Patch to copy source bundles along with bundles during
> -------------------------------------------------------
>
> Key: DIRSTUDIO-540
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
> Project: Directory Studio
> Issue Type: Improvement
> Environment: N/A
> Reporter: Hasan Ceylan
> Assignee: Felix Knecht
> Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-540) Patch to copy source bundles along
with bundles during
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Seelmann updated DIRSTUDIO-540:
--------------------------------------
Issue Type: Improvement (was: Bug)
Felix, could you take a look at this patch?
> Patch to copy source bundles along with bundles during
> -------------------------------------------------------
>
> Key: DIRSTUDIO-540
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
> Project: Directory Studio
> Issue Type: Improvement
> Environment: N/A
> Reporter: Hasan Ceylan
> Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-540) Patch to copy source bundles
along with bundles during
Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763928#action_12763928 ]
Felix Knecht commented on DIRSTUDIO-540:
----------------------------------------
I'm not sure, if this is the expected result, but running the patched plugin on the studio trunk I get only two (2 !) artifact sources missing. Can this really be correct?
[WARNING] Following source artifact is not available in the local repository 'org.eclipse.core.filesystem.linux:x86_64:jar:sources:1.0.100.v20080604-1400'
[WARNING] Following source artifact is not available in the local repository 'org.eclipse.swt.gtk.linux:x86_64:jar:sources:3.5.0.v3550b'
Reformatted logging to make more clear which artifact sources are missing (from AbstractStudioMojo):
protected void completeArtifactItems( List<ArtifactItem> artifactItems, boolean relaxed )
throws MojoExecutionException
{
List<String> warnings = new ArrayList<String>();
// Get and complete artifacts
for ( Iterator<ArtifactItem> artifactItem = artifactItems.iterator(); artifactItem.hasNext(); )
{
ArtifactItem item = artifactItem.next();
try
{
// make sure we have a version.
if ( StringUtils.isEmpty( item.getVersion() ) )
{
fillMissingArtifactVersion( item );
}
item.setArtifact( this.getArtifact( item ) );
}
catch ( Exception e )
{
if ( relaxed )
{
warnings.add( "Following source artifact is not available in the local repository '"
+ item.getGroupId() + ":" + item.getArtifactId() + ":" + item.getType() + ":"
+ item.getClassifier() + ":" + item.getVersion() + "'" );
}
else
{
throw new MojoExecutionException(
"Following source artifact is not available in the local repository '" + item.getGroupId()
+ ":" + item.getArtifactId() + ":" + item.getType() + ":" + item.getClassifier() + ":"
+ item.getVersion() + "'", e );
}
}
}
if ( relaxed && !warnings.isEmpty() )
{
for ( String warn : warnings )
{
getLog().warn( warn );
}
}
}
> Patch to copy source bundles along with bundles during
> -------------------------------------------------------
>
> Key: DIRSTUDIO-540
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
> Project: Directory Studio
> Issue Type: Improvement
> Environment: N/A
> Reporter: Hasan Ceylan
> Assignee: Felix Knecht
> Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-540) Patch to copy source bundles
along with bundles during
Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763045#action_12763045 ]
Felix Knecht commented on DIRSTUDIO-540:
----------------------------------------
I'll do, just give me a day or two ;-)
> Patch to copy source bundles along with bundles during
> -------------------------------------------------------
>
> Key: DIRSTUDIO-540
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
> Project: Directory Studio
> Issue Type: Improvement
> Environment: N/A
> Reporter: Hasan Ceylan
> Assignee: Felix Knecht
> Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRSTUDIO-540) Patch to copy source bundles along
with bundles during
Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Knecht resolved DIRSTUDIO-540.
------------------------------------
Resolution: Fixed
Patch applied with small modifications. Thanks to Hasan for providing the patch.
> Patch to copy source bundles along with bundles during
> -------------------------------------------------------
>
> Key: DIRSTUDIO-540
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
> Project: Directory Studio
> Issue Type: Improvement
> Environment: N/A
> Reporter: Hasan Ceylan
> Assignee: Felix Knecht
> Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.