[GitHub] [netbeans] neilcsmith-net commented on pull request #5617: turn github PR squash feature off.

["neilcsmith-net (via GitHub)" <gi...@apache.org>]

neilcsmith-net commented on PR #5617:
URL: https://github.com/apache/netbeans/pull/5617#issuecomment-1466085307

   > Reading the 2020 thread in the mailing list I see that @neilcsmith-net wanted to keep the squash option in github. It eased things during releases, IIRC.
   
   Don't use my past opinion as a benchmark! :smile:  I'm currently +1 to disabling both squash and rebase options.
   
   One of my concerns in the past thread, and still, is losing the relationship between PRs and commits, eg. by squashing and merging to master locally.  Now that everyone seems to understand that they can force push to any PR branch (by default) that seems less of an issue.  If it wasn't for edge cases, I'd argue to also disable all direct pushes to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists