You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/08/27 23:05:54 UTC

Re: Review Request 61809: From code logic analysis, we should optimize the flush function of HDFSAuditDestination class.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61809/
-----------------------------------------------------------

(Updated 八月 27, 2017, 11:05 p.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Summary (updated)
-----------------

From code logic analysis, we should optimize the flush function of HDFSAuditDestination class.


Bugs: RANGER-1745
    https://issues.apache.org/jira/browse/RANGER-1745


Repository: ranger


Description
-------

From the performance and code logic analysis, we should optimize the flush function of HDFSAuditDestination class. The reason is as following:
1. Its logic is not clear. There are duplicate code and repeated judgment.
2. Through my tests, in the case of large data, the log io will have a big impact on performance.


Diffs
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 66d8504 


Diff: https://reviews.apache.org/r/61809/diff/1/


Testing
-------


Thanks,

Qiang Zhang