You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/02/09 13:28:28 UTC

[GitHub] ivankelly commented on a change in pull request #1135: Specify repo in MavenClassLoader

ivankelly commented on a change in pull request #1135: Specify repo in MavenClassLoader
URL: https://github.com/apache/bookkeeper/pull/1135#discussion_r167226700
 
 

 ##########
 File path: tests/integration-tests-utils/src/test/java/org/apache/bookkeeper/tests/MavenClassLoaderTest.java
 ##########
 @@ -39,4 +39,9 @@ public void testNoZooKeeperInterference() throws Exception {
                                    org.apache.zookeeper.KeeperException.NoNodeException.class));
     }
 
+    @Test
+    public void testLoadSpecifyingMavenRepo() throws Exception {
 
 Review comment:
   What's the issue with remote resources for a test that'll only normally run in CI? If github is down, the CI job will fail much earlier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services