You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@devlake.apache.org by "tcvall86 (via GitHub)" <gi...@apache.org> on 2024/05/06 07:13:46 UTC

[I] [Bug][Github] In version 0.21.0 github app payload adds empty token on subsequent tries [incubator-devlake]

tcvall86 opened a new issue, #7425:
URL: https://github.com/apache/incubator-devlake/issues/7425

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   When adding a connection to Github Cloud using Github App - test and connection works.
   ![image](https://github.com/apache/incubator-devlake/assets/46521292/26263c22-6ddc-421e-8afc-3d309fdfb970)
   ```json
   {
       "success": true,
       "message": "success",
       "causes": null,
       "data": null,
       "login": "myapp-devlake",
       "warning": false,
       "installations": [
           {
               "id": <redacted>,
               "account": {
                   "login": "myorg"
               }
           }
       ]
   }
   ```
   However in subsequent tests we get
   ```json
   {
       "success": false,
       "message": "invalid private key (400)\nWraps: (2) invalid key: Key must be a PEM encoded PKCS1 or PKCS8 key\nError types: (1) *hintdetail.withDetail (2) *errors.errorString",
       "causes": null,
       "data": null
   }
   ```
   
   Re-editing the connection also shows private key and id as invalid, even though just re-pasting the key works
   It seems like something get's messed up when the key is saved. It also adds an additional token field to the request if that makes any difference.
   
   ![image](https://github.com/apache/incubator-devlake/assets/46521292/ae47b826-2c79-49fd-8b85-26d1c786224a)
   
   In 0.18.0 we could add this app successfully but we had to manually search for repos. We are hoping this version would solve that.
   
   Trying to add data scopes generates
   
   TypeError: (n ?? []).map is not a function
   
   But since the test is failing previously I think that is expected
   
   ### What do you expect to happen
   
   We should be able to reliably save the connection for the Github App in version 0.21
   
   ### How to reproduce
   
   Add a github app with required scopes https://devlake.apache.org/docs/v0.18/Configuration/GitHub/#github-apps and then try to add app as connection. After saved, re-test and it fails.
   
   ### Anything else
   
   All the time as far as we can tell
   
   ### Version
   
   v0.21.0
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug][Github] In version 0.21.0 github app payload adds empty token on subsequent tries and fails to load private key [incubator-devlake]

Posted by "tcvall86 (via GitHub)" <gi...@apache.org>.
tcvall86 closed issue #7425: [Bug][Github] In version 0.21.0 github app payload adds empty token on subsequent tries and fails to load private key
URL: https://github.com/apache/incubator-devlake/issues/7425


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug][Github] In version 0.21.0 github app payload adds empty token on subsequent tries and fails to load private key [incubator-devlake]

Posted by "tcvall86 (via GitHub)" <gi...@apache.org>.
tcvall86 commented on issue #7425:
URL: https://github.com/apache/incubator-devlake/issues/7425#issuecomment-2095338751

   Nvm it was the config-ui update that took sometime to load. It works now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org