[GitHub] [airflow] kaxil commented on a change in pull request #14625: Support remote logging in elasticsearch with filebeat 7

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #14625:
URL: https://github.com/apache/airflow/pull/14625#discussion_r648693279



##########
File path: airflow/config_templates/config.yml
##########
@@ -1999,6 +1999,20 @@
       type: string
       example: ~
       default: "asctime, filename, lineno, levelname, message"
+    - name: host_field
+      description: |
+        The field where host name is stored (normally either `host` or `host.name`)

Review comment:
       ```suggestion
           The field where host name is stored (normally either ``host`` or ``host.name``)
   ```

##########
File path: airflow/config_templates/config.yml
##########
@@ -1999,6 +1999,20 @@
       type: string
       example: ~
       default: "asctime, filename, lineno, levelname, message"
+    - name: host_field
+      description: |
+        The field where host name is stored (normally either `host` or `host.name`)
+      version_added: 2.1.1
+      type: string
+      example: ~
+      default: "host"
+    - name: offset_field
+      description: |
+        The field where offset is stored (normally either `offset` or `log.offset`)

Review comment:
       ```suggestion
           The field where offset is stored (normally either ``offset`` or ``log.offset``)
   ```
   
   Since it is `.rst`

##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -992,6 +992,12 @@ json_format = False
 # Log fields to also attach to the json output, if enabled
 json_fields = asctime, filename, lineno, levelname, message
 
+# The field where host name is stored (normally either `host` or `host.name`)
+host_field = host
+
+# The field where offset is stored (normally either `offset` or `log.offset`)
+offset_field = offset

Review comment:
       ```suggestion
   # The field where host name is stored (normally either ``host`` or ``host.name``)
   host_field = host
   
   # The field where offset is stored (normally either ``offset`` or ``log.offset``)
   offset_field = offset
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org