You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/05/10 11:12:47 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #4192: Deffered Object Store Config Parsing (#4191)

tustvold opened a new pull request, #4192:
URL: https://github.com/apache/arrow-rs/pull/4192

   _Draft as builds on #4189_ 
   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #4191
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   This closes #4191 whilst also making me happier that the current pattern is workable to support things like durations, etc...
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4192: Deffered Object Store Config Parsing (#4191)

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4192:
URL: https://github.com/apache/arrow-rs/pull/4192#discussion_r1190224800


##########
object_store/src/client/mod.rs:
##########
@@ -43,6 +45,14 @@ fn map_client_error(e: reqwest::Error) -> super::Error {
 static DEFAULT_USER_AGENT: &str =
     concat!(env!("CARGO_PKG_NAME"), "/", env!("CARGO_PKG_VERSION"),);
 
+/// Configuration keys for [`ClientOptions`]
+#[derive(PartialEq, Eq, Hash, Clone, Debug, Copy, Deserialize, Serialize)]
+#[non_exhaustive]
+pub enum ClientConfigKey {
+    /// Allow non-TLS, i.e. non-HTTPS connections
+    AllowHttp,
+}
+

Review Comment:
   > Do you think this is something object_store wants to do in a follow-up
   
   Yes, 100%



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold merged pull request #4192: Deffered Object Store Config Parsing (#4191)

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4192:
URL: https://github.com/apache/arrow-rs/pull/4192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4192: Deffered Object Store Config Parsing (#4191)

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4192:
URL: https://github.com/apache/arrow-rs/pull/4192#discussion_r1191053449


##########
object_store/src/client/mod.rs:
##########
@@ -43,6 +45,14 @@ fn map_client_error(e: reqwest::Error) -> super::Error {
 static DEFAULT_USER_AGENT: &str =
     concat!(env!("CARGO_PKG_NAME"), "/", env!("CARGO_PKG_VERSION"),);
 
+/// Configuration keys for [`ClientOptions`]
+#[derive(PartialEq, Eq, Hash, Clone, Debug, Copy, Deserialize, Serialize)]
+#[non_exhaustive]
+pub enum ClientConfigKey {
+    /// Allow non-TLS, i.e. non-HTTPS connections
+    AllowHttp,
+}
+

Review Comment:
   https://github.com/apache/arrow-rs/pull/4202 is the next step in exposing client options to the python side



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] roeap commented on a diff in pull request #4192: Deffered Object Store Config Parsing (#4191)

Posted by "roeap (via GitHub)" <gi...@apache.org>.
roeap commented on code in PR #4192:
URL: https://github.com/apache/arrow-rs/pull/4192#discussion_r1190195509


##########
object_store/src/client/mod.rs:
##########
@@ -43,6 +45,14 @@ fn map_client_error(e: reqwest::Error) -> super::Error {
 static DEFAULT_USER_AGENT: &str =
     concat!(env!("CARGO_PKG_NAME"), "/", env!("CARGO_PKG_VERSION"),);
 
+/// Configuration keys for [`ClientOptions`]
+#[derive(PartialEq, Eq, Hash, Clone, Debug, Copy, Deserialize, Serialize)]
+#[non_exhaustive]
+pub enum ClientConfigKey {
+    /// Allow non-TLS, i.e. non-HTTPS connections
+    AllowHttp,
+}
+

Review Comment:
   Some users in delta-rs are asking to expose more client options on the python side, for this having some more keys defined might be helpful. Do you think this is something object_store wants to do in a follow-up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org