You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2009/02/04 12:37:59 UTC
[jira] Created: (JCR-1963) determinatino of property state
difference should skip binary values
determinatino of property state difference should skip binary values
--------------------------------------------------------------------
Key: JCR-1963
URL: https://issues.apache.org/jira/browse/JCR-1963
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: jackrabbit-jcr2spi
Reporter: Michael Dürig
o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1963) Determination of property state
difference should skip binary values
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1963:
-------------------------------
Fix Version/s: (was: 1.6.0)
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Affects Versions: 1.5.0
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Fix For: 1.5.5
>
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
workspace "security" can be backup and restore or not
Posted by yanshaozhiGmail <ya...@gmail.com>.
HI:
Is the workspace "security" can be backup and restore or not?
any method ?
thanks very much .
2009-02-05
yanjie
[jira] Commented: (JCR-1963) Determination of property state
difference should skip binary values
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670721#action_12670721 ]
angela commented on JCR-1963:
-----------------------------
with just having quickly looked at the code, i would assume that this shouldn't do too much harm (though it's not what i would call perfect). in the worst case (prop wasn't modified) this would generate a superfluous internal notification...
if, however, we would also address issue #JCR-1012 there was (most probably) another way to determine if a property has changed (thinking of some sort of modcnt or rev. number)... this could be an more elegant approach...
anyway: michael, can you take care of this one? thanks
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Michael Dürig
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1963) Determination of property state
difference should skip binary values
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676636#action_12676636 ]
Michael Dürig commented on JCR-1963:
------------------------------------
Further investigation shows that
a) property diffing is sometimes done even if the result is not used by the caller.
b) property diffing occurs very frequently when the same session is accessed concurrently from within different threads.
I will fix a) in jcr2spi. Case b) is invalid since it's the client's responsibility to synchronize access to sessions.
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Michael Dürig
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1963) Determination of property state
difference should skip binary values
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig resolved JCR-1963.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.6.0
Fixed at revision: 747839
This is a fix for case a) from above. Property are now only diffed if necessary.
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Fix For: 1.6.0
>
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (JCR-1963) Determination of property state
difference should skip binary values
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig reopened JCR-1963:
--------------------------------
Reopening for 1.5.0
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Affects Versions: 1.5.0
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Fix For: 1.6.0
>
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1963) Determination of property state
difference should skip binary values
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig updated JCR-1963:
-------------------------------
Affects Version/s: 1.5.0
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Affects Versions: 1.5.0
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Fix For: 1.6.0
>
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1963) Determination of property state
difference should skip binary values
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig updated JCR-1963:
-------------------------------
Summary: Determination of property state difference should skip binary values (was: determinatino of property state difference should skip binary values)
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Michael Dürig
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1963) Determination of property state
difference should skip binary values
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig resolved JCR-1963.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.5.5
Fixed at revision: 766760
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Affects Versions: 1.5.0
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Fix For: 1.5.5, 1.6.0
>
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1963) Determination of property state
difference should skip binary values
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig reassigned JCR-1963:
----------------------------------
Assignee: Michael Dürig
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Michael Dürig
> Assignee: Michael Dürig
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should alway consider two binary values to be different. The current implementation compares two binary values with equals(). An implementation will in general have to do a byte by byte comparison of both values. This is most likely always more expensive than considering the values different right from the start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.