You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@excalibur.apache.org by "Jim Apple (JIRA)" <de...@excalibur.apache.org> on 2008/02/20 10:23:43 UTC
[jira] Created: (FORTRESS-24) Useless length check in
fortress/meta/src/java/org/apache/avalon/fortress/tools/Component.java
Useless length check in fortress/meta/src/java/org/apache/avalon/fortress/tools/Component.java
----------------------------------------------------------------------------------------------
Key: FORTRESS-24
URL: https://issues.apache.org/jira/browse/FORTRESS-24
Project: Excalibur Fortress
Issue Type: Bug
Components: Implementation
Affects Versions: 1.1
Reporter: Jim Apple
Priority: Minor
http://www.google.com/codesearch?hl=en&q=+%5Cw%7B9%7D%5C+%5C!%5C%3D%5C+null%5C+%5C%7C%5C%7C%5C+%5Cw%7B9%7D%5C.%5Cw*%5C(+show:Hj1pNaTZhMg:DqZL3QbYD5E:qjugdXajwK4&sa=N&cd=1&ct=rc&cs_p=http://apache.edgescape.com/excalibur/excalibur-fortress/source/avalon-fortress-tools-1.1-src.zip&cs_f=avalon-fortress-tools-1.1/src/java/org/apache/avalon/fortress/tools/Component.java#first
line 368:
if ( className != null || className.length() > 0 )
the || should probably be &&
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Closed: (FORTRESS-24) Useless length check in
fortress/meta/src/java/org/apache/avalon/fortress/tools/Component.java
Posted by "Carsten Ziegeler (JIRA)" <de...@excalibur.apache.org>.
[ https://issues.apache.org/jira/browse/FORTRESS-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed FORTRESS-24.
------------------------------------
Resolution: Fixed
Fix Version/s: 1.3.2
Thanks for reporting this.
> Useless length check in fortress/meta/src/java/org/apache/avalon/fortress/tools/Component.java
> ----------------------------------------------------------------------------------------------
>
> Key: FORTRESS-24
> URL: https://issues.apache.org/jira/browse/FORTRESS-24
> Project: Excalibur Fortress
> Issue Type: Bug
> Components: Implementation
> Affects Versions: 1.1
> Reporter: Jim Apple
> Priority: Minor
> Fix For: 1.3.2
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> http://www.google.com/codesearch?hl=en&q=+%5Cw%7B9%7D%5C+%5C!%5C%3D%5C+null%5C+%5C%7C%5C%7C%5C+%5Cw%7B9%7D%5C.%5Cw*%5C(+show:Hj1pNaTZhMg:DqZL3QbYD5E:qjugdXajwK4&sa=N&cd=1&ct=rc&cs_p=http://apache.edgescape.com/excalibur/excalibur-fortress/source/avalon-fortress-tools-1.1-src.zip&cs_f=avalon-fortress-tools-1.1/src/java/org/apache/avalon/fortress/tools/Component.java#first
> line 368:
> if ( className != null || className.length() > 0 )
> the || should probably be &&
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Commented: (FORTRESS-24) Useless length check in
fortress/meta/src/java/org/apache/avalon/fortress/tools/Component.java
Posted by "Jim Apple (JIRA)" <de...@excalibur.apache.org>.
[ https://issues.apache.org/jira/browse/FORTRESS-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570626#action_12570626 ]
Jim Apple commented on FORTRESS-24:
-----------------------------------
version 1.2 as well,
http://www.google.com/codesearch?hl=en&q=+%5Cw%7B9%7D%5C+%5C!%5C%3D%5C+null%5C+%5C%7C%5C%7C%5C+%5Cw%7B9%7D%5C.%5Cw*%5C(+show:jypgqn3okUM:Ph0xIl6hzIE:SlX648yLaVA&sa=N&cd=2&ct=rc&cs_p=http://apache.edgescape.com/excalibur/excalibur-fortress/source/excalibur-fortress-meta-1.2-src.zip&cs_f=excalibur-fortress-meta-1.2/src/java/org/apache/avalon/fortress/tools/Component.java#first
line 411
> Useless length check in fortress/meta/src/java/org/apache/avalon/fortress/tools/Component.java
> ----------------------------------------------------------------------------------------------
>
> Key: FORTRESS-24
> URL: https://issues.apache.org/jira/browse/FORTRESS-24
> Project: Excalibur Fortress
> Issue Type: Bug
> Components: Implementation
> Affects Versions: 1.1
> Reporter: Jim Apple
> Priority: Minor
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> http://www.google.com/codesearch?hl=en&q=+%5Cw%7B9%7D%5C+%5C!%5C%3D%5C+null%5C+%5C%7C%5C%7C%5C+%5Cw%7B9%7D%5C.%5Cw*%5C(+show:Hj1pNaTZhMg:DqZL3QbYD5E:qjugdXajwK4&sa=N&cd=1&ct=rc&cs_p=http://apache.edgescape.com/excalibur/excalibur-fortress/source/avalon-fortress-tools-1.1-src.zip&cs_f=avalon-fortress-tools-1.1/src/java/org/apache/avalon/fortress/tools/Component.java#first
> line 368:
> if ( className != null || className.length() > 0 )
> the || should probably be &&
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Commented: (FORTRESS-24) Useless length check in
fortress/meta/src/java/org/apache/avalon/fortress/tools/Component.java
Posted by "Jim Apple (JIRA)" <de...@excalibur.apache.org>.
[ https://issues.apache.org/jira/browse/FORTRESS-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582830#action_12582830 ]
Jim Apple commented on FORTRESS-24:
-----------------------------------
This will also cause a NullPointerException for a null className.
> Useless length check in fortress/meta/src/java/org/apache/avalon/fortress/tools/Component.java
> ----------------------------------------------------------------------------------------------
>
> Key: FORTRESS-24
> URL: https://issues.apache.org/jira/browse/FORTRESS-24
> Project: Excalibur Fortress
> Issue Type: Bug
> Components: Implementation
> Affects Versions: 1.1
> Reporter: Jim Apple
> Priority: Minor
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> http://www.google.com/codesearch?hl=en&q=+%5Cw%7B9%7D%5C+%5C!%5C%3D%5C+null%5C+%5C%7C%5C%7C%5C+%5Cw%7B9%7D%5C.%5Cw*%5C(+show:Hj1pNaTZhMg:DqZL3QbYD5E:qjugdXajwK4&sa=N&cd=1&ct=rc&cs_p=http://apache.edgescape.com/excalibur/excalibur-fortress/source/avalon-fortress-tools-1.1-src.zip&cs_f=avalon-fortress-tools-1.1/src/java/org/apache/avalon/fortress/tools/Component.java#first
> line 368:
> if ( className != null || className.length() > 0 )
> the || should probably be &&
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org