You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/17 16:15:19 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
eolivelli opened a new pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990
Fixes #8974
### Motivation
In certain cases peeking messages on compresses topics return an error, see #8974 because Airlift does not support readonly ByteBuffers, because they do not give access to the underlying array)
### Modifications
Copy the ByteByffer in case of unsupported buffer type
### Verifying this change
This change adds new tests that reproduce the error and demonstrate that the problem is fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990#issuecomment-747551170
> I had to copy the ByteBuffer, no other way :-(
That is ok, this is only used when peeking messages. For regular producer/consumer compression it's done on the direct memory instead, without copy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990#issuecomment-749009769
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990#issuecomment-749624600
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990#issuecomment-747553521
@merlimat I wasn't able to reproduce the problem with and end-to-end test (using the existing end-to-end tests about compression).
If you feel strong I can try to reproduce it better, but probably I will have to start a full (with real BK/ZK...) I am not sure it is worth
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990#issuecomment-749035780
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990#issuecomment-748969673
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990#issuecomment-747543696
@merlimat @codelipenghui @rdhabalia PTAL
I had to copy the ByteBuffer, no other way :-(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990#issuecomment-748963667
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #8990: Issue 8974: Peeking at compressed messages throws an exception (Readonly buffers not supported by Airlift)
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #8990:
URL: https://github.com/apache/pulsar/pull/8990#issuecomment-747569653
> but probably I will have to start a full (with real BK/ZK...) I am not sure it is worth
There are already tests that are spinning up real BK, just need to inherit from `BkEnsemblesTestBase`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org