You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2007/05/10 13:05:15 UTC

[jira] Created: (JCR-911) Remove sanityCheck() from ItemImpl.getSession()

Remove sanityCheck() from ItemImpl.getSession()
-----------------------------------------------

                 Key: JCR-911
                 URL: https://issues.apache.org/jira/browse/JCR-911
             Project: Jackrabbit
          Issue Type: Bug
    Affects Versions: 1.3, 1.2.3, 1.2.2, 1.2.1, 1.1.1, 1.1, 1.0.1, 1.0, 0.9
            Reporter: Jukka Zitting
         Assigned To: Jukka Zitting
            Priority: Minor


The following code causes an InvalidItemStateException to be thrown for no good reason:

    Property property = ...;
    property.setValue((Value) null);
    property.getSession();

There are cases (I'm looking at one right now) where it's good to be able to access the session of an Item even if it has already been invalidated.

The simple fix is to remove the sanityCheck() call from ItemImpl.getSession(). I'll do that unless someone has a good reason why the sanity check should be kept.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-911) Remove sanityCheck() from ItemImpl.getSession()

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-911:
------------------------------

    Fix Version/s:     (was: 1.4)
                   1.3.1

Merged to the 1.3 branch in revision 544279.

> Remove sanityCheck() from ItemImpl.getSession()
> -----------------------------------------------
>
>                 Key: JCR-911
>                 URL: https://issues.apache.org/jira/browse/JCR-911
>             Project: Jackrabbit
>          Issue Type: Bug
>    Affects Versions: 0.9, 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3, 1.3
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.3.1
>
>
> The following code causes an InvalidItemStateException to be thrown for no good reason:
>     Property property = ...;
>     property.setValue((Value) null);
>     property.getSession();
> There are cases (I'm looking at one right now) where it's good to be able to access the session of an Item even if it has already been invalidated.
> The simple fix is to remove the sanityCheck() call from ItemImpl.getSession(). I'll do that unless someone has a good reason why the sanity check should be kept.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-911) Remove sanityCheck() from ItemImpl.getSession()

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-911.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

Fixed in revision 537122.

> Remove sanityCheck() from ItemImpl.getSession()
> -----------------------------------------------
>
>                 Key: JCR-911
>                 URL: https://issues.apache.org/jira/browse/JCR-911
>             Project: Jackrabbit
>          Issue Type: Bug
>    Affects Versions: 0.9, 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3, 1.3
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.4
>
>
> The following code causes an InvalidItemStateException to be thrown for no good reason:
>     Property property = ...;
>     property.setValue((Value) null);
>     property.getSession();
> There are cases (I'm looking at one right now) where it's good to be able to access the session of an Item even if it has already been invalidated.
> The simple fix is to remove the sanityCheck() call from ItemImpl.getSession(). I'll do that unless someone has a good reason why the sanity check should be kept.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.