You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2026/07/01 04:40:34 UTC
[GH] (rocketmq/fix/enable-retry-topic-v2-by-default): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git/fix/enable-retry-topic-v2-by-default has failed.
Run started by GitHub user wang-jiahua (triggered by wang-jiahua).
Head commit for run:
8ff7c1603e225f07553386f8e6f84d925d09f9a9 / wangjiahua.wjh <wa...@alibaba-inc.com>
[ISSUE #9633] Enable retry topic V2 by default to prevent name collision
V1 retry topic naming uses underscore as separator (%RETRY%{cid}_{topic}),
which is ambiguous because both topic and group names may contain underscores.
This causes different (group, topic) pairs to map to the same retry topic,
leading to cross-topic consumption and potential data leakage.
V2 naming (using '+' separator) already exists but was disabled by default.
This commit changes enableRetryTopicV2 default from false to true.
Existing V1 retry topics are still readable because
retrieveMessageFromPopRetryTopicV1 remains true (backward compatible).
Changes:
- BrokerConfig: enableRetryTopicV2 default false -> true
- KeyBuilderTest: 3 new tests demonstrating V1 collision and V2 correctness
Report URL: https://github.com/apache/rocketmq/actions/runs/28492469936
With regards,
GitHub Actions via GitBox