You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2017/06/20 15:54:11 UTC
[1/2] beam git commit: Retries http code 0 (usually network error)
Repository: beam
Updated Branches:
refs/heads/master eae0d05bd -> c1a2226c9
Retries http code 0 (usually network error)
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/6e435722
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/6e435722
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/6e435722
Branch: refs/heads/master
Commit: 6e4357225477d6beb4cb9735255d1759f4fab168
Parents: eae0d05
Author: Eugene Kirpichov <ki...@google.com>
Authored: Mon Jun 19 11:56:29 2017 -0700
Committer: Luke Cwik <lc...@google.com>
Committed: Tue Jun 20 08:53:36 2017 -0700
----------------------------------------------------------------------
.../org/apache/beam/sdk/util/RetryHttpRequestInitializer.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/6e435722/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/util/RetryHttpRequestInitializer.java
----------------------------------------------------------------------
diff --git a/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/util/RetryHttpRequestInitializer.java b/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/util/RetryHttpRequestInitializer.java
index e5b48d3..a23bee3 100644
--- a/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/util/RetryHttpRequestInitializer.java
+++ b/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/util/RetryHttpRequestInitializer.java
@@ -96,8 +96,9 @@ public class RetryHttpRequestInitializer implements HttpRequestInitializer {
@Override
public boolean isRequired(HttpResponse response) {
int statusCode = response.getStatusCode();
- return (statusCode / 100 == 5) || // 5xx: server error
- statusCode == 429; // 429: Too many requests
+ return (statusCode == 0) // Code 0 usually means no response / network error
+ || (statusCode / 100 == 5) // 5xx: server error
+ || statusCode == 429; // 429: Too many requests
}
});
}
[2/2] beam git commit: Retries http code 0 (usually network error)
Posted by lc...@apache.org.
Retries http code 0 (usually network error)
This closes #3394
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/c1a2226c
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/c1a2226c
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/c1a2226c
Branch: refs/heads/master
Commit: c1a2226c90bed7b7bf68a4cd240c849dc46e55ac
Parents: eae0d05 6e43572
Author: Luke Cwik <lc...@google.com>
Authored: Tue Jun 20 08:53:59 2017 -0700
Committer: Luke Cwik <lc...@google.com>
Committed: Tue Jun 20 08:53:59 2017 -0700
----------------------------------------------------------------------
.../org/apache/beam/sdk/util/RetryHttpRequestInitializer.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------